Implement BEL control code event emission with decoupled UI rendering - #7
Open
Chris-Moller wants to merge 2 commits into
Open
Implement BEL control code event emission with decoupled UI rendering#7Chris-Moller wants to merge 2 commits into
Chris-Moller wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…al handlers Add onBell callback to Terminal and MogTermEngine that fires when BEL (0x07) is encountered in ground state. The renderer provides configurable audio (Web Audio API) and visual (CSS flash) bell handlers. OSC-terminating BEL correctly does not trigger the bell event. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Implement BEL control code event emission with decoupled UI rendering
Type: feature | Size: small | Priority: undefined
Description
Implement event-based BEL (bell) control code handling in the terminal engine. When the engine encounters a BEL character (ASCII 0x07), it should emit a bell event that the UI layer can hook into for audio or visual feedback. The parser already routes BEL through the
onExecutecallback andTerminal._execute()currently has a no-opcase 0x07: break. This change adds event emission at that point using the existing callback-based event model, keeping the engine decoupled from rendering. The UI/renderer layer then provides default audio bell (e.g., Web Audio API) and visual flash (CSS class toggle) handlers that consumers can customize or disable.Acceptance Criteria
Implementation Summary
Implemented BEL control code event emission in Terminal/MogTermEngine with configurable audio and visual bell handlers in the renderer
Completed:
Changed files:
src/terminal.jssrc/renderer.jssrc/mogterm.csssrc/engine.tstest/terminal.test.jsTests were run and passed.
Commits
Implemented by Venice Executor · task
711ff3e8-fdf3-4493-a607-3d38ff791194