Upgrade Vitest to v4 and improve Windows path handling - #2
Open
czenzel wants to merge 1 commit into
Open
Conversation
Bumps Vitest/tooling across the workspace (including coverage config) and updates package templates/dependencies to newer Cloudflare and test-stack versions. Adjusts Vitest config for v4 option changes, normalizes secret/bootstrap config paths to portable POSIX-style locations, and fixes integration workerd spawning/cleanup on Windows to avoid orphaned processes and locked temp directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several dependency updates, cross-platform path handling improvements, and enhancements to the
spawn-workerdintegration test utility to better support Windows environments. The most important changes are summarized below:Dependency Updates:
vitestand@vitest/coverage-v8to version4.1.10in multiplepackage.jsonfiles for improved testing features and compatibility. [1] [2]@cloudflare/workers-typesto^5.20260801.1in template and app packages. [1] [2]autocannonto^2.0.1ingroundflarepackage.Cross-Platform Path Handling:
path.joinwithpath/posix.joinand normalized path separators to/inBootstrapStateStoreandFileSecretStoreto ensure consistent behavior on Windows and Unix systems. Added a helpernormalizePortablePathfor this purpose. [1] [2] [3] [4] [5]Integration Test Improvements (Windows Support):
spawn-workerd.tsto select the correct nativeworkerdbinary for the current platform and architecture, including direct execution of the.exeon Windows to avoid orphaned child processes and locked temp directories. [1] [2]removeWorkdirfunction with retry logic to handle Windows file handle delays during test cleanup. Updated all relevant cleanup calls to use this function. [1] [2] [3] [4] [5]Test Configuration Simplification:
vitestconfiguration files by removing unnecessarypoolOptionsnesting and clarifying comments. [1] [2]