[LLV] Refactor JS distribution#635
Open
FranekKubis wants to merge 3 commits into
Open
Conversation
c049db4 to
872c04f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor JS distribution: ship
local_live_view.jspre-bundled inside the hex package instead of building it user-side via npm. End users now import via package name (import "local_live_view") instead of relative vendor path, andmix llv.builddrops the npm/node steps entirely.Changes
Library side:
local-live-view/package.jsonwithmain: "priv/static/local_live_view.js"for esbuild's NODE_PATH resolution (NODE_PATH points to "deps" directory).priv/static/{local_live_view.js, iframe.mjs, AtomVM.mjs, AtomVM.wasm}committed (pre-bundled at release time viaassets/bundle.mjs).mix llv.buildsimplified: copies runtime files fromdeps/local_live_view/priv/static/to user'spriv/static/assets/js/, then builds WASM. No npm, no node.llv.installtemplate injectsimport { LLVEngine } from "local_live_view"(wasfrom "../vendor/local_live_view.js").Examples (
local-lv-{compare,forms,thermostat,pong,burrito}):build.mjs+ node watcher).assets/package.jsondeclares"local_live_view": "workspace:*"so pnpm symlinks LLV intonode_modules/(path deps don't getdeps/<name>/from Mix — workspace fills the gap in monorepo).bundlePathsfixed to matchout_dir(/assets/js/wasm/bundle.avm).pnpm-workspace.yamlincludeslocal-live-viewand missing example entries.