Skip to content

[LocalLiveView] Generator tests#616

Open
FranekKubis wants to merge 15 commits into
mainfrom
fk/llvinstall-tests
Open

[LocalLiveView] Generator tests#616
FranekKubis wants to merge 15 commits into
mainfrom
fk/llvinstall-tests

Conversation

@FranekKubis

@FranekKubis FranekKubis commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Tests for mix llv.install (test/mix/tasks/llv_install_test.exs) — one test per inject_* step + generate_local_project + idempotency, using Igniter.Test.phx_test_project().
  • mix test step added to .github/workflows/local_live_view_build.yml.

Side effect: a few inject_* steps used real-FS path checks and silently no-op'd outside the target project's cwd — refactored to Igniter's virtual-FS APIs.

Test plan

  • CI green on the LocalLiveView workflow
  • mix llv.install still works on a fresh phx.new project

@FranekKubis FranekKubis marked this pull request as ready for review May 28, 2026 10:56
@FranekKubis FranekKubis requested a review from mat-hek May 28, 2026 10:56

@mat-hek mat-hek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an integration test, that runs mix phx.new, adds llv to deps, updates home.html.heex, runs llv.install, mix setup and mix phx.server, visits the page with playwright and checks if HelloLocal renders properly

@FranekKubis FranekKubis force-pushed the fk/llvinstall-tests branch from 1f924b1 to da6a135 Compare May 29, 2026 11:30
@FranekKubis FranekKubis requested a review from mat-hek June 9, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants