[Landing] llv examples animation#613
Open
mmietla wants to merge 8 commits into
Open
Conversation
mmietla
changed the title
FranekKubis
approved these changes
May 29, 2026
jgonet
reviewed
Jun 8, 2026
| <h1>[Local Runtime] User List:</h1> | ||
| <div data-value="errors-list"> | ||
| <%= for error <- @errors do %> | ||
| <p style="color:red;">{error}</p> |
| </div> | ||
| <div class="bordered" data-value="users-list"> | ||
| <h2 class="title">[Local Runtime] User List:</h2> | ||
| <%= if @users == [] do %> |
Comment on lines
+57
to
+58
| env: | ||
| CXXFLAGS: "-std=c++20" |
Member
There was a problem hiding this comment.
Would be nice to leave a comment why we need it so we can remove it later if it stops being necessary.
| end | ||
|
|
||
| def handle_event(event, params, socket) | ||
| when event in ["validate", "save", "generate_random"] do |
Member
There was a problem hiding this comment.
Or ~w(validate save generate_random)
|
|
||
| def handle_event(event, params, socket) | ||
| when event in ["validate", "save", "generate_random"] do | ||
| effective_socket = |
Member
There was a problem hiding this comment.
This is weird:
- why the assign starts with underscore?
- do we need two versions of socket?
| <div | ||
| id={`llv-code-body-${i}`} | ||
| class="code-body-wrap llv-scroll" | ||
| style={i === 0 ? "" : "display:none"} |
Member
There was a problem hiding this comment.
Maybe this should be a toggleable class?
Comment on lines
+15
to
+19
| const libDir = path.resolve( | ||
| fileURLToPath(import.meta.url), | ||
| "../../../../..", | ||
| "examples/local-lv-forms/local/lib", | ||
| ); |
Comment on lines
+157
to
+158
| const result = | ||
| errors > 0 ? `errors: ${errors}` : users > 0 ? `users: ${users}` : "ok"; |
Member
There was a problem hiding this comment.
Maybe this shouldn't be nested ternary?
Comment on lines
+175
to
181
| function handlePresentation(payload: unknown) { | ||
| const { block, event, assigns } = payload as { | ||
| block: string | null; | ||
| event: string; | ||
| assigns: Record<string, unknown>; | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
This looks weird, why we add unknown and then immediately cast?
Comment on lines
+121
to
+128
| if (ann?.block) | ||
| (node.properties as Record<string, unknown>)["data-block"] = ann.block; | ||
|
|
||
| if (ann?.defpGroup) | ||
| (node.properties as Record<string, unknown>)["data-defp-group"] = ann.defpGroup; | ||
|
|
||
| if (ann?.defpHeader) | ||
| (node.properties as Record<string, unknown>)["data-defp-header"] = "true"; |
Member
There was a problem hiding this comment.
I feel like this could be written a but more clearer by defining types or is functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-05-21.at.12.39.22.mov
Screen.Recording.2026-05-21.at.12.39.49.mov