feat: enable physical device for iOS profiling by stachbial · Pull Request #38 · software-mansion/argent

stachbial · 2026-03-23T19:03:35Z

renamed list-simulators to list-devices which behaves as previously with optional arg that triggers xcrun devicectl list .... run
links it to ios-profiler-start tool

…to @stachbial/ios-profiler-for-physical-device

latekvo · 2026-03-23T19:09:24Z

I would much prefer a single tool that lists both devices and simulators, then CLEARLY labels which device is a simulator and which is a physical device. Then the agent should have it CLEARLY explained what are the limitations & reasons for using a simulator over a device and vice versa.

Unless there are arguments against this approach, my arguments are:

We have to clearly explain the differences between the approaches either way, we don't want the agent to confuse these options
Having separate tools still is more confusing than having one no matter how clearly you explain the difference with seemingly no quantifiable reason for having these tools split
More tools take up more context, having a single one takes up less context.

stachbial · 2026-03-23T19:19:08Z

I would much prefer a single tool that lists both devices and simulators, then CLEARLY labels which device is a simulator and which is a physical device. Then the agent should have it CLEARLY explained what are the limitations & reasons for using a simulator over a device and vice versa.

Unless there are arguments against this approach, my arguments are:

We have to clearly explain the differences between the approaches either way, we don't want the agent to confuse these options

Having separate tools still is more confusing than having one no matter how clearly you explain the difference with seemingly no quantifiable reason for having these tools split

More tools take up more context, having a single one takes up less context.

I hear you, that was my initial thought actually. Then I thought: due to the fact that most of Argent's features are heavily bound to simserver, querying the physical devices all the time would seem redundant and steering it with just a flag - harder to grasp for the agent. The standalone tool is rather easier to distinguish in such use case.
Regarding the simulator vs physical device differences explanation, I am not very found of that approach - I think we should always default to simulator and talk about/work with real devices if the user explicitly says so in the prompt (current implementation).

…to @stachbial/ios-profiler-for-physical-device

…bial/ios-profiler-for-physical-device

…evices fetch

stachbial · 2026-03-26T16:40:57Z

I would much prefer a single tool that lists both devices and simulators, then CLEARLY labels which device is a simulator and which is a physical device. Then the agent should have it CLEARLY explained what are the limitations & reasons for using a simulator over a device and vice versa.
Unless there are arguments against this approach, my arguments are:

We have to clearly explain the differences between the approaches either way, we don't want the agent to confuse these options

Having separate tools still is more confusing than having one no matter how clearly you explain the difference with seemingly no quantifiable reason for having these tools split

More tools take up more context, having a single one takes up less context.

I hear you, that was my initial thought actually. Then I thought: due to the fact that most of Argent's features are heavily bound to simserver, querying the physical devices all the time would seem redundant and steering it with just a flag - harder to grasp for the agent. The standalone tool is rather easier to distinguish in such use case. Regarding the simulator vs physical device differences explanation, I am not very found of that approach - I think we should always default to simulator and talk about/work with real devices if the user explicitly says so in the prompt (current implementation).

Eventually, a unified list-devices tool was made with physical device fetch optionally executed based on boolean arg. cc: @latekvo @pFornagiel

…er-for-physical-device # Conflicts: # packages/skills/skills/argent-simulator-interact/SKILL.md # packages/ui/src/api/client.ts

latekvo

Nice. Probably also adjust the title to reflect what's being done in this PR.

latekvo · 2026-03-31T16:52:54Z

I'm so lost right now. What did I just review? The comments are here but the diff is from a different PR?

edit:

hmm could this be the cause?

…ol desc

stachbial · 2026-03-31T20:43:16Z

I'm so lost right now. What did I just review? The comments are here but the diff is from a different PR?

@latekvo Yep It looks like You reviewed a different PR, probably a a stale diff in your cache 👀

…bial/ios-profiler-for-physical-device

latekvo

Great work, i wish we could merge this really soon ❤️
Just noticed i had these 2 comments pending for the last week - they're just nitpicks.

…er-for-physical-device # Conflicts: # README.md # packages/skills/skills/argent-react-native-app-workflow/SKILL.md # packages/tool-server/src/tools/simulator/list-simulators.ts # packages/tool-server/src/utils/setup-registry.ts

…n prior merge)

Three independent bugs in the Android-path code that reviewers repro'd: 1. uiautomator entity decoder double-decoded. The decoder ran numeric references as one replace pass, then each of the five named entities as its own pass. An ampersand decoded in the first pass fed straight into the second: `&lt;` (correct XML encoding of the literal string `<`) collapsed to `<`, violating XML 1.0 §4.6. Replaced with a single regex alternation so every match is consumed once. 2. `launch-app` Android path used two different launch mechanisms — a blocking `am start -W` when the caller passed an `activity`, and a fire-and-forget `monkey … LAUNCHER 1` when they didn't. The monkey path returned as soon as the intent was injected, leaving a window where describe/tap raced a still-forking process. Unified on `am start -W` by resolving the default activity up-front via `cmd package resolve-activity --brief`. Also replaced the brittle `/Error|Exception/ && !/Status: ok/` matcher with a positive match on `Status: ok` — the old regex false-succeeded on `Status: null` (activity threw in onCreate) and would have false-failed if Android ever dropped the `Status:` banner from a release that keeps benign strings like `Activity: com.example.ErrorReportingActivity` in the output. 3. `describe` Android path shell-chained cleanup with `&&`, so a failing `uiautomator dump` (keyguard, MFA flap, secure overlay) short-circuited before `rm -f` ever ran and leaked a file per attempt under /data/local/tmp. One-char fix: trailing `; rm -f` instead of `&& rm -f`. Regression tests added for all three: `&lt;` / `&lt;` / `&amp;` stay literal, `am start` success/failure permutations, and a shell-string assertion pinning the `;` before `rm -f`.

…arch) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Reconciles the physical-device iOS profiler branch with main's large tool-server restructure (tools/simulator/* split into per-tool dirs + a new multi-platform tools/devices abstraction; ios-profiler renamed to native-profiler; mcp -> argent-mcp; new argent-cli/installer/ui packages). Conflict resolution: - setup-registry.ts: took main (already registers listDevicesTool from the new tools/devices/list-devices path; the branch's only change was subsumed). - auto-screenshot.test.ts: kept main's boot-device rename (list-devices was already agreed by both sides). - 4 SKILL.md docs: took main's structure/tool names (boot-device, iOS+Android), preserved the branch's physical-device guidance where it adds value, and updated stale references (ios-profiler-start -> native-profiler-start, argent-ios-profiler -> argent-native-profiler). Ported the branch's genuine new value onto main's architecture: - utils/ios-device.ts -> utils/ios-physical-device.ts (renamed to avoid clashing with main's utils/ios-devices.ts; dropped the duplicate simulator detector in favour of main's robust execFileSync-based one). - native-profiler-start.ts: auto-detect now branches on checkIsSimulator and uses devicectl-based detectRunningAppOnDevice for physical devices. - tools/devices/list-devices.ts: added opt-in include_physical_devices flag that appends connected physical iOS devices (kind: "physical") via devicectl. - removed the orphaned tools/simulator/list-devices.ts (superseded). - completed the child_process mock in two ios-instruments tests so the new top-level promisify(execFile) import doesn't throw under partial mocks. Submodule argent-private fast-forwarded to 73c9491 (physical device research, a superset of main's 27dac19). Verified: tsc --build clean; tool-server 875/875, argent-mcp 65/65, and all other package suites green; all test files typecheck. (Pre-existing, merge- independent macOS-symlink failure in argent-installer's uninstall test remains.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

stachbial added 2 commits March 23, 2026 19:59

feat: enable ios profiler for physical device

38024f5

Merge branch 'main' of github.com:software-mansion-labs/radon-lite in…

60e5b2b

…to @stachbial/ios-profiler-for-physical-device

stachbial requested a review from latekvo March 23, 2026 19:03

stachbial added 3 commits March 24, 2026 10:46

Merge branch 'main' of github.com:software-mansion-labs/radon-lite in…

9ae200c

…to @stachbial/ios-profiler-for-physical-device

Merge branch 'main' of github.com:software-mansion/argent into @stach…

47eb874

…bial/ios-profiler-for-physical-device

feat: rename list-simulators to list-devices with optional physical d…

224e0cd

…evices fetch

stachbial added 2 commits March 31, 2026 17:50

chore: rm unnecessary await from js-runtime-debbugger

d712aba

Merge remote-tracking branch 'origin/main' into @stachbial/ios-profil…

a74e6a7

…er-for-physical-device # Conflicts: # packages/skills/skills/argent-simulator-interact/SKILL.md # packages/ui/src/api/client.ts

latekvo reviewed Mar 31, 2026

View reviewed changes

feat: mv agent guidelines on sim vs physical devices to skill from to…

9b698fa

…ol desc

stachbial changed the title ~~enable ios profiler session for physical device~~ enable physical device for iOS profiling Mar 31, 2026

Merge branch 'main' of github.com:software-mansion/argent into @stach…

31c4f41

…bial/ios-profiler-for-physical-device

latekvo reviewed Apr 7, 2026

View reviewed changes

Comment thread packages/tool-server/src/blueprints/js-runtime-debugger.ts Outdated

Comment thread packages/tool-server/src/utils/ios-device.ts Outdated

fix: physical device scan err handling

77cbf15

stachbial changed the title ~~enable physical device for iOS profiling~~ feat: enable physical device for iOS profiling Apr 16, 2026

stachbial added 3 commits April 16, 2026 19:13

Merge remote-tracking branch 'origin/main' (tree already reconciled i…

f6af860

…n prior merge)

chore: prettier formatting on merged files

8408426

pFornagiel and others added 2 commits June 9, 2026 09:33

chore: bump argent-private submodule to 73c9491 (physical device rese…

61ade52

…arch) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable physical device for iOS profiling#38

feat: enable physical device for iOS profiling#38
stachbial wants to merge 15 commits into
mainfrom
@stachbial/ios-profiler-for-physical-device

stachbial commented Mar 23, 2026 •

edited

Loading

Uh oh!

latekvo commented Mar 23, 2026

Uh oh!

stachbial commented Mar 23, 2026

Uh oh!

stachbial commented Mar 26, 2026 •

edited

Loading

Uh oh!

latekvo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

latekvo commented Mar 31, 2026 •

edited

Loading

Uh oh!

stachbial commented Mar 31, 2026 •

edited

Loading

Uh oh!

latekvo left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

stachbial commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

latekvo commented Mar 23, 2026

Uh oh!

stachbial commented Mar 23, 2026

Uh oh!

stachbial commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

latekvo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

latekvo commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stachbial commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

latekvo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stachbial commented Mar 23, 2026 •

edited

Loading

stachbial commented Mar 26, 2026 •

edited

Loading

latekvo commented Mar 31, 2026 •

edited

Loading

stachbial commented Mar 31, 2026 •

edited

Loading

latekvo left a comment •

edited

Loading