Add dark mode toggle with persistence and FOUC fix#65
Merged
Conversation
Resolve theme on load from the saved choice or prefers-color-scheme, apply it before first paint via an inline script, and add a header toggle in AppShell that persists to localStorage. Closes #44 Co-authored-by: Deric Walintukan <4350404+dwalintukan@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #44. Adds a dark/light toggle in the AppShell header, resolves the theme on load from the saved choice or
prefers-color-scheme, persists tolocalStorage, and sets the class before first paint via an inline script to avoid FOUC.Not verified: no Node toolchain on the runner —
npm run buildandnpm testwere not run.Generated with Claude Code