Skip to content

[SofaGL] Start a Sofa.SofaGL Module#109

Merged
jnbrunet merged 9 commits into
sofa-framework:masterfrom
psomers3:master
Feb 9, 2021
Merged

[SofaGL] Start a Sofa.SofaGL Module#109
jnbrunet merged 9 commits into
sofa-framework:masterfrom
psomers3:master

Conversation

@psomers3

@psomers3 psomers3 commented Feb 5, 2021

Copy link
Copy Markdown
Contributor

I have started the bindings for a Sofa.SofaGL module so that other visualization tools from python can be used (two examples are also added for this). I imagine I should change the naming of the file that I do this bindings in because I started by thinking I need to wrap the drawtool and realized later that I don't need to. I can change the names to whatever you all feel appropriate if this small addition is worth it.

@psomers3 psomers3 changed the title Start a Sofa.SofaGL Module [SofaGL] Start a Sofa.SofaGL Module Feb 5, 2021
@jnbrunet jnbrunet added the enhancement New feature or request label Feb 5, 2021
@jnbrunet

jnbrunet commented Feb 5, 2021

Copy link
Copy Markdown
Contributor

Hey @psomers3

Thanks a lot for this PR. Not everyone take the time to bring back their patch to the community. It is very appreciated.

I will try to review it on Monday.

@psomers3

psomers3 commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

Out of curiousity, why are Sofa.GL and Sofa.Type the only modules with a "."?

@jnbrunet

jnbrunet commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

Out of curiousity, why are Sofa.GL and Sofa.Type the only modules with a "."?

Sofa.GL and Sofa.Type are the first two modules of the "next generation" of SOFA.

You can also have a look here to get an idea of the remaining modules that should be (hopefully) created in the upcoming months.

@jnbrunet

jnbrunet commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Hey @psomers3 ,

Your PR looks good, and would be ready to be merged.

Did you had something else to add here?

@psomers3

psomers3 commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

I guess looking at it, it would be more proper to add a description for the functions to the docs file... I can do that in a little bit.

@jnbrunet

jnbrunet commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

All right, I'll change the status to WIP (work in progress). Simply replace this PR label to "status: to review" once you have finished adding commits.

@psomers3

psomers3 commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

@jnbrunet I can't change the label since I'm not a contributor, but I've added my changes and think it's good to go.

@jnbrunet jnbrunet merged commit 8151cfe into sofa-framework:master Feb 9, 2021
@guparan guparan added this to the v21.06 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pr: status ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants