AMPR-271: Fix ampere-core-test-fixtures never reaching Maven Central - #751
Merged
wow-miley merged 1 commit intoSep 3, 2026
Conversation
|
Concept staleness check — clean. No tracked-source changes need a concept update. |
ampere-core-test-fixtures had a mavenPublishing { coordinates(...) } block
and was claimed as published in the AMPR-250 CHANGELOG entry, but the
publish workflow's actual gradlew command line never mentioned it — so it
silently never reached Central across 0.12.0 and 0.13.0. Socket worked
around the gap by vendoring built jars/klibs/aars into their own repo
(SCKT-442), which this was meant to make unnecessary.
Auditing the rest of the publish workflow against every module's
mavenPublishing block found the same gap on ampere-bindings-android,
ampere-bindings-apple, ampere-cli, and ampere-eval — all configured for
publishing but missing from the workflow. All five are now included in
both the real and dry-run publish steps.
Add a verifyPublishWorkflowCoverage Gradle task (wired into ci.yml and
publish.yml) that fails the build if any module with a mavenPublishing
block is missing from publish.yml's publish command, so this class of bug
can't recur silently.
0.13.0's missing ampere-core-test-fixtures artifact is not backfilled;
the fix takes effect starting with the next tagged release.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
wow-miley
force-pushed
the
miley/ampr-271-publish-ampere-core-test-fixtures-to-maven-central-for-real
branch
from
September 3, 2026 01:10
f432b50 to
b02c9dd
Compare
wow-miley
deleted the
miley/ampr-271-publish-ampere-core-test-fixtures-to-maven-central-for-real
branch
September 3, 2026 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ampere-core-test-fixtureswas declared for publishing (mavenPublishing { coordinates(...) }) and the AMPR-250 CHANGELOG entry claimed it was published, but the publish workflow's actual./gradlew ... publishAllPublicationsToMavenCentralRepositorycommand line never mentioned it — so it silently never reached Maven Central across the 0.12.0 and 0.13.0 releases. Socket worked around the gap by vendoring the built jars/klibs/aars into their own repo (SCKT-442), which this was meant to make unnecessary.What this does
mavenPublishing { }block against the publish workflow and found the same gap onampere-bindings-android,ampere-bindings-apple,ampere-cli, andampere-eval— all configured for publishing but missing from the workflow. All five modules are now included in both the real and dry-run publish steps.verifyPublishWorkflowCoverageGradle task, wired intoci.ymlandpublish.yml, that fails the build if any module with amavenPublishing { }block is missing frompublish.yml's publish command — so "declared for publishing" and "actually published" can't drift apart again without a build failure catching it.[Unreleased].Not in scope
0.13.0's missingampere-core-test-fixturesartifact is not backfilled here (per discussion — would require an irreversible manual publish with prod credentials). The fix applies starting with the next tagged release (0.14.0+).Linked: AMPR-271. A follow-up SCKT ticket will track Socket adopting the real artifact once it's live and removing their vendored
libs/repo/link/socket/ampere-core-test-fixtures*workaround.🤖 Generated with Claude Code