You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR renames several CSS variables (e.g., --section-background-color to --section-background, --input-background-color to --input-background, and --focus-color to --focus-border) which breaks integration with ThemeBasedStylingGenerator.kt. The generator explicitly searches for the old variable names (see cross-file context) to inject IDE-specific theme colors. Consequently, this fallback settings page will fail to adapt to the user's IDE theme (such as Light or High Contrast modes) and will remain stuck with the hardcoded dark-themed fallback values provided in the :root block.
The collectData function now uses the placeholder attribute as a fallback value for cliBaseDownloadURL if the input field is empty. Using UI placeholders as data defaults is brittle; if a developer changes the placeholder for UX guidance (e.g., to 'Enter URL here...'), that descriptive string will be saved as a valid configuration value, potentially breaking CLI downloads. This behavior is also inconsistent with other fields like cliPath, which correctly return an empty string when cleared, allowing the backend to handle defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!