Skip to content

fix: update settings fallback html styling [IDE-1926]#808

Open
andrewrobinsonhodges-snyk wants to merge 1 commit intomasterfrom
fix/IDE-1926_update-settings-fallback-html-styling
Open

fix: update settings fallback html styling [IDE-1926]#808
andrewrobinsonhodges-snyk wants to merge 1 commit intomasterfrom
fix/IDE-1926_update-settings-fallback-html-styling

Conversation

@andrewrobinsonhodges-snyk
Copy link
Copy Markdown
Contributor

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Apr 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Code Coverage

Total Project Coverage 47.16%

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Theming Regression 🟠 [major]

The PR renames several CSS variables (e.g., --section-background-color to --section-background, --input-background-color to --input-background, and --focus-color to --focus-border) which breaks integration with ThemeBasedStylingGenerator.kt. The generator explicitly searches for the old variable names (see cross-file context) to inject IDE-specific theme colors. Consequently, this fallback settings page will fail to adapt to the user's IDE theme (such as Light or High Contrast modes) and will remain stuck with the hardcoded dark-themed fallback values provided in the :root block.

--input-background: var(--vscode-input-background, #3c3c3c);
--section-background: var(--vscode-editor-inactiveSelectionBackground, #2a2d2e);

/* Borders */
--input-border: var(--vscode-input-border, #454545);
--border-color: var(--vscode-panel-border, #454545);
--focus-border: var(--vscode-focusBorder, #007acc);
Brittle Logic 🟡 [minor]

The collectData function now uses the placeholder attribute as a fallback value for cliBaseDownloadURL if the input field is empty. Using UI placeholders as data defaults is brittle; if a developer changes the placeholder for UX guidance (e.g., to 'Enter URL here...'), that descriptive string will be saved as a valid configuration value, potentially breaking CLI downloads. This behavior is also inconsistent with other fields like cliPath, which correctly return an empty string when cleared, allowing the backend to handle defaults.

cliBaseDownloadURL: get('cliBaseDownloadURL').value || get('cliBaseDownloadURL').placeholder,
📚 Repository Context Analyzed

This review considered 21 relevant code sections from 12 files (average relevance: 0.66)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant