Skip to content

chore: Remove redundant uninstall/install steps from dev deploy#255

Open
danskmt wants to merge 2 commits intomainfrom
chore/CLI-1435-remove-redundant-dev-extension-install
Open

chore: Remove redundant uninstall/install steps from dev deploy#255
danskmt wants to merge 2 commits intomainfrom
chore/CLI-1435-remove-redundant-dev-extension-install

Conversation

@danskmt
Copy link
Copy Markdown
Contributor

@danskmt danskmt commented Apr 3, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages are release-note ready, emphasizing what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Removes the redundant az devops extension uninstall and install-extension-to-dev-org.js steps from ci-deploy-dev.sh. These are unnecessary because tfx extension publish --share-with auto-updates already-installed extensions in the org. The uninstall/install cycle was causing 409 / TF1590010 ("already installed") race conditions that marked CI as failed even though the extension was successfully published.

install-extension-to-dev-org.ts is left intact for manual / first-time use.

Adds a 30-second delay before "Launch Test Pipelines" to allow Azure DevOps to propagate the updated extension. Previously this delay came from the install-extension-to-dev-org.js step (which slept 30s after installing). Without it, test pipelines can fail with "Could not queue the build because there were validation errors or warnings" because the extension isn't fully available yet.

Where should the reviewer start?

  • scripts/ci-deploy-dev.sh — removed uninstall block and install-to-org block
  • .circleci/config.yml — new "Wait for extension availability" step before "Launch Test Pipelines"

How should this be manually tested?

  1. Push a branch, confirm deploy_dev CI job succeeds without running uninstall or install-extension-to-dev-org.js.
  2. Verify the dev extension is updated in the Azure DevOps org after publish.

What's the product update that needs to be communicated to CLI users?

None. Internal CI pipeline change only.

Risk assessment (Low | Medium | High)?

Low — removes steps that were redundant with tfx publish --share-with behavior.

Any background context you want to provide?

tfx extension publish --share-with auto-updates extensions already installed in a shared org. The explicit uninstall + installExtensionByName cycle was a workaround that introduced eventual-consistency races (409 errors). Removing both eliminates the root cause of flaky dev deploy CI runs.

What are the relevant tickets?

CLI-1435
CLI-1426

@danskmt danskmt requested review from a team as code owners April 3, 2026 11:57
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Apr 3, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@danskmt danskmt force-pushed the chore/CLI-1435-remove-redundant-dev-extension-install branch 3 times, most recently from 74aae57 to a35352e Compare April 3, 2026 13:39
@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@danskmt danskmt force-pushed the chore/CLI-1435-remove-redundant-dev-extension-install branch from a35352e to 929bd8d Compare April 3, 2026 13:50
@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 9 relevant code sections from 9 files (average relevance: 0.73)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant