chore: Remove redundant uninstall/install steps from dev deploy#255
Open
chore: Remove redundant uninstall/install steps from dev deploy#255
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
74aae57 to
a35352e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a35352e to
929bd8d
Compare
This comment has been minimized.
This comment has been minimized.
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Removes the redundant
az devops extension uninstallandinstall-extension-to-dev-org.jssteps fromci-deploy-dev.sh. These are unnecessary becausetfx extension publish --share-withauto-updates already-installed extensions in the org. The uninstall/install cycle was causing 409 / TF1590010 ("already installed") race conditions that marked CI as failed even though the extension was successfully published.install-extension-to-dev-org.tsis left intact for manual / first-time use.Adds a 30-second delay before "Launch Test Pipelines" to allow Azure DevOps to propagate the updated extension. Previously this delay came from the
install-extension-to-dev-org.jsstep (which slept 30s after installing). Without it, test pipelines can fail with "Could not queue the build because there were validation errors or warnings" because the extension isn't fully available yet.Where should the reviewer start?
scripts/ci-deploy-dev.sh— removed uninstall block and install-to-org block.circleci/config.yml— new "Wait for extension availability" step before "Launch Test Pipelines"How should this be manually tested?
deploy_devCI job succeeds without running uninstall or install-extension-to-dev-org.js.What's the product update that needs to be communicated to CLI users?
None. Internal CI pipeline change only.
Risk assessment (Low | Medium | High)?
Low — removes steps that were redundant with
tfx publish --share-withbehavior.Any background context you want to provide?
tfx extension publish --share-withauto-updates extensions already installed in a shared org. The explicit uninstall +installExtensionByNamecycle was a workaround that introduced eventual-consistency races (409 errors). Removing both eliminates the root cause of flaky dev deploy CI runs.What are the relevant tickets?
CLI-1435
CLI-1426