docs(media-player): document how duration_secs is resolved and add the 1.1.0 migration entry - #1919
Draft
snowplow-claude-review[bot] wants to merge 1 commit into
Draft
docs(media-player): document how duration_secs is resolved and add the 1.1.0 migration entry#1919snowplow-claude-review[bot] wants to merge 1 commit into
snowplow-claude-review[bot] wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
documentation | b24cc52 | Commit Preview URL Branch Preview URL |
Aug 21 2026, 06:47 AM |
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The media-player data model resolves
duration_secsfrom a play's own reported value, falling back to a media-level maximum when the play reported none. That resolution has never been documented —durationdoes not appear anywhere on the data-model page today — which is why users have had to ask how the number is derived.Two pages updated, paired with the package change that makes the play-first resolution correct.
Changes
How the media duration is resolvedsection (after Identifiers), covering the play-first resolution, the media-level fallback, the columns derived from it (is_complete_play,content_watched_percent, and themedia_statsrollups), and a note that the fallback is scoped to the events in a single run whilemedia_stats.duration_secsis not.Upgrading to 1.1.0entry matching the existing per-version format: a bolded full-refresh recommendation forsnowplow_media_player_baseandsnowplow_media_player_media_stats, justified bysnowplow__upsert_lookback_daysand the cross-run weighted average inmedia_stats; a behavior-changes list; an explicit statement thatmedia_stats.duration_secsis unchanged; and a note that no configuration or schema change is required. It cross-links to the new section.Notes for the reviewer
1.1.0heading is taken from the package's minor bump (latest shipped schema file isdbtMediaPlayer_1.0.1.json). It needs to match whatever version the package repo actually releases.dbtMediaPlayer_1.1.0.jsonschema file or version-list entry is included: git history shows those arrive via the automated release PR rather than being hand-authored. Flagged rather than silently omitted.Verification
yarn install --immutablethenyarn build, exit 0.docusaurus.config.tssetsonBrokenLinksandonBrokenAnchorstothrow, so every internal link and the cross-page anchor is validated at build time, and the built HTML renders the new section anchor as linked.Draft PR opened for review — please verify and run CI before merging.