Add identity gdpr erasure - #1804
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
documentation | 2c65693 | Commit Preview URL Branch Preview URL |
Aug 21 2026, 09:45 AM |
Documentation style reviewA few items to address — mostly minor, plus one merge-blocker the author already flagged. 1. "fulfil" → "fulfill" (US spelling)
CLAUDE.md → Writing style: "Use US English spelling." The US form is fulfill (double L). Replace each instance in 2. Bold used for non-UI emphasis
CLAUDE.md → Grammar and formatting: "Use bold only for UI elements (buttons, page titles)." The style guide reinforces this (bold = buttons, page titles, tabs, menus). These are values, not UI elements — drop the bold: 3. Pending "do not merge" gate
Outside pure style scope, but worth surfacing: the author has marked the page as not-ready-to-merge until Console exposes the API URL the Authenticate section sends readers to find. Either resolve that dependency or convert this into a draft/hold before merge. Also remove the comment once the gate clears. 4. Minor: heading voice
CLAUDE.md → Headings and organization: "Prefer imperative voice." Consider Otherwise the page is well-structured: frontmatter is complete, internal links use absolute paths ending in |
88680be to
6d5aa80
Compare
6d5aa80 to
321e0e0
Compare
Greptile SummaryAdds documentation for previewing and executing GDPR erasure requests against the Identities graph.
Confidence Score: 4/5The invalid Snowplow ID examples should be corrected before merging because customers copying either request can fail to erase the intended identity. Both executable examples pass a UUID as Files Needing Attention: docs/identities/erasure/index.md
|
| Filename | Overview |
|---|---|
| docs/identities/erasure/index.md | Adds the complete erasure API guide, but its request and response examples use UUIDs where the documented Snowplow ID schema requires sp_-prefixed IDs. |
| docs/identities/index.md | Adds a valid introductory link to the new erasure guide. |
Reviews (1): Last reviewed commit: "Add identity gdpr erasure" | Re-trigger Greptile
| {"type": "user_id", "value": "alice@example.com"}, | ||
| {"type": "user_id", "value": "nobody@example.com"} | ||
| ], | ||
| "snowplow_ids": ["550e8400-e29b-41d4-a716-446655440000"], |
There was a problem hiding this comment.
When a customer copies either erasure request, the UUID-formatted snowplow_id contradicts the documented ^sp_[A-Za-z2-7]{26}$ schema, causing the request to target an invalid ID and fail to erase the intended identity. The corresponding response examples repeat the same invalid format.
There was a problem hiding this comment.
Fixed in 2c65693. Both requests and both response bodies now use sp_-prefixed IDs matching the ^sp_[A-Za-z2-7]{26}$ pattern on the identity 2-0-0 entity. The truncated ... forms in the responses are gone too, so every ID on the page is copyable as-is.
What changed?
Added identity erasure docs.