Move translations and main snapblocks library code to ext.snapblocks ReourceLoader module - #9
Merged
Merged
Conversation
…ourceLoader module
Member
|
Sounds good |
Collaborator
Author
|
Personally, I would like to only load the translations (because it's taking up about ~170kb in transfer size right now) if they are needed on a page, do you see any issue with that approach, @ego-lay-atman-bay? |
Member
|
That's not a bad idea. Since this is a primarily english wiki, I don't think loading other languages is needed. If pages have some language set for them, then maybe we could detect that and load the language in snapblocks (though I would have to actually split all the languages into separate files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to load less modules, which should help speed up loading times slightly as MediaWiki has to deal with less metadata now.