Skip to content

Garde la position de chaque coffre quand les coffres verrouillés sont cachés - #9

Open
Watherfoxx wants to merge 2 commits into
snakehugo:masterfrom
Watherfoxx:master
Open

Garde la position de chaque coffre quand les coffres verrouillés sont cachés#9
Watherfoxx wants to merge 2 commits into
snakehugo:masterfrom
Watherfoxx:master

Conversation

@Watherfoxx

Copy link
Copy Markdown

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 433730bb56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

} else {
if (!CONFIG.getBoolean("show-locked-vaults", true)) {
consumer.accept(null);
consumer.accept(getHiddenLockedVaultItem(num, replacements));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enable paging for hidden placeholder slots

When show-locked-vaults is false and max-vault-amount is left at its default -1, this now adds an AIR GuiItem for each locked vault before any owned high-numbered vault. Those placeholders consume paginated slots, but the selector still disables next/previous buttons when maxVaults == -1, so a player with sparse permissions such as only axvaults.vault.80 has that vault moved onto page 2 with no way to navigate to it from the selector. Consider treating unlimited mode as pageable based on the highest emitted slot, or avoid adding placeholders beyond reachable pages.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant