Config refactor#70
Conversation
Changes the getMaxUseTime Item Mixin to exclude shields and spears. Fixes occasional damage applying through shields and spears acting weird.
Potential fix for shields and spears
# Conflicts: # src/main/java/net/snackbag/tt20/mixin/item/ItemMixin.java
26.1 Support
There was a problem hiding this comment.
Finally got to reviewing!
It's really nice, and makes everything so much easier. However, the package structure is a bit weird; the whole Nvm, it's not connected to the mod yetrework package is redundant, it can all go into the config package.
In some places you changed logging from TT20.LOGGER to System.out, which is probably just a little happy accident, but needs to be taken care of
It's generally a pretty large PR, so I'll take your word for that it functions and properly transfers old configurations of servers to the new system. Furthermore, since I took so long with my underwhelming review you will probably have to solve the merge conflicts.
|
Yeah, hi P.S. Should've probably just marked it as draft as it's not really in "ready for production" state |
# Conflicts: # build.gradle # gradle.properties # settings.gradle # src/main/java/net/snackbag/tt20/TT20.java # src/main/java/net/snackbag/tt20/command/MainCommand.java # src/main/java/net/snackbag/tt20/config/BlockEntityMaskConfig.java # src/main/java/net/snackbag/tt20/config/JSONConfiguration.java # src/main/java/net/snackbag/tt20/config/MainConfig.java # src/main/java/net/snackbag/tt20/config/lib/utils/Mask.java # src/main/java/net/snackbag/tt20/config/lib/utils/RegistryIndex.java # src/main/java/net/snackbag/tt20/mixin/DedicatedServerWatchdogMixin.java # src/main/java/net/snackbag/tt20/mixin/LivingEntityMixin.java # src/main/java/net/snackbag/tt20/mixin/PlayerEntityMixin.java # src/main/java/net/snackbag/tt20/mixin/PortalManagerMixin.java # src/main/java/net/snackbag/tt20/mixin/ServerPlayerManagerMixin.java # src/main/java/net/snackbag/tt20/mixin/accessor/ServerPlayerAccessor.java # src/main/java/net/snackbag/tt20/mixin/client/ChatHudMixin.java # src/main/java/net/snackbag/tt20/mixin/client/IntegratedServerMixin.java # src/main/java/net/snackbag/tt20/mixin/fluid/LavaFluidMixin.java # src/main/java/net/snackbag/tt20/mixin/fluid/WaterFluidMixin.java # src/main/java/net/snackbag/tt20/mixin/item/ItemEntityMixin.java # src/main/java/net/snackbag/tt20/mixin/item/ItemMixin.java # src/main/java/net/snackbag/tt20/mixin/world/AbstractBlockMixin.java # src/main/java/net/snackbag/tt20/mixin/world/GameRulesMixin.java # src/main/java/net/snackbag/tt20/mixin/world/ServerLevelMixin.java # src/main/java/net/snackbag/tt20/mixin/world/WorldChunkMixin.java # src/main/resources/fabric.mod.json # stonecutter.gradle
|
Now it uses FernConfig (moved to a separate lib) Other changes:
|
|
Actually Fern is not ready, I'm refactoring it |
# Conflicts: # build.gradle # src/main/java/net/snackbag/tt20/mixin/ServerPlayerManagerMixin.java # src/main/java/net/snackbag/tt20/mixin/world/GameRulesMixin.java # src/main/java/net/snackbag/tt20/mixin/world/LevelChunkMixin.java # src/main/java/net/snackbag/tt20/util/Mask.java # src/main/java/net/snackbag/tt20/util/RegistryIndex.java
|
Fern seems to be pretty stable now |
|
LGTM, but add migration of old configurations! |
3 participants
Supports TOML & JSON5
Isn't actually connected to mod or versioned, exists only to be added into unified branch