expand + icon menu to support photo, contact and file attachments.#54
Open
mildrette wants to merge 3 commits into
Open
expand + icon menu to support photo, contact and file attachments.#54mildrette wants to merge 3 commits into
mildrette wants to merge 3 commits into
Conversation
…are contact, and share file. when you press +, the menu opens. when you choose something, the menu closes first so the screen does not overlap
Member
|
Please attach a screenshot - crop the part of the changes |
sherlockwisdom
requested changes
Jun 4, 2026
| } | ||
|
|
||
| val coroutineScope = rememberCoroutineScope() | ||
| val contactPickerLauncher = rememberLauncherForActivityResult( |
Member
There was a problem hiding this comment.
Please move this to an external composable
…atcompose to seperate composables
…atcompose to seperate composables, other changes include a updated dropdown to buttomSheet and a test file for conversationsComponents testing for the following checks that index and total number shows on the screen, check that placeholder text shows when search is empty, check that the + button is visible, tapping + button sheet show up with photo contact and file, that each button in the bottom shows, send button shows when you type something, send button hides when text field is empty, checks that tapping the send button actually triger the send action, check that the resend options shows up, and delete also shows and all test passed
Member
Author
|
@sherlockwisdom i have pushed new changes to this PR,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the + button only opened the image picker.
Now, it opens a menu with additional attachment options.
Changes
File:
ui/components/ConversationsComponents.ktisMenuExpandedstate to manage menu visibilityTesting
Closes #49