Skip to content

Pin internal preset references to v1 tag#29

Merged
toshi0806 merged 1 commit into
mainfrom
pin-internal-preset-refs
Jun 3, 2026
Merged

Pin internal preset references to v1 tag#29
toshi0806 merged 1 commit into
mainfrom
pin-internal-preset-refs

Conversation

@toshi0806
Copy link
Copy Markdown
Member

Summary

Follow-up to #28. Pin the nested github>smkwlab/.github (→ default.json) references inside latex.json and elixir.json to the moving major tag #v1.

- "extends": ["github>smkwlab/.github", "workarounds:all"],
+ "extends": ["github>smkwlab/.github#v1", "workarounds:all"],

Why

Consumer repos will pin to github>smkwlab/.github:latex#v1. However, Renovate does not propagate a parent preset's ref to nested presets — github>smkwlab/.github without a ref resolves at the default branch. Without this change, a "pinned" consumer would still pick up default.json (which holds the auto-merge policy) from main instantly, defeating the purpose of pinning.

Pinning the internal references makes the entire preset chain resolve at the controlled v1 tag.

Addresses the Copilot review feedback on smkwlab/.github (unpinned preset reference) at the preset-internal layer.

Rollout note

After this merges, the v1 tag will be moved forward to this commit (and a v1.6.0 release cut), so that :latex#v1 resolves to the preset-containing, internally-pinned version. Consumer PRs (latex-environment#141, thesis-management-tools#437, latex-release-action#61) will then be updated to reference :latex#v1.

Pin the nested 'github>smkwlab/.github' (default.json) references inside
latex.json and elixir.json to the moving major tag #v1, so that pinned
consumers (extends github>smkwlab/.github:latex#v1) resolve the entire
preset chain — including the auto-merge policy in default.json — at a
controlled version instead of the default branch.

Addresses Copilot review feedback about unpinned preset references.
Follow-up to #28.
Copilot AI review requested due to automatic review settings June 3, 2026 07:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the internal Renovate preset inheritance in this repo so that latex.json and elixir.json extend the default.json preset at the moving major tag v1, ensuring consumers who use :latex#v1 / :elixir#v1 don’t accidentally resolve nested presets from the default branch.

Changes:

  • Update latex.json to extend github>smkwlab/.github#v1 instead of the default-branch reference.
  • Update elixir.json to extend github>smkwlab/.github#v1 instead of the default-branch reference.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
latex.json Pins the nested base preset reference to #v1 while keeping workarounds:all.
elixir.json Pins the nested base preset reference to #v1 for consistent chain resolution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@toshi0806 toshi0806 merged commit b3f8bdd into main Jun 3, 2026
2 checks passed
@toshi0806 toshi0806 deleted the pin-internal-preset-refs branch June 3, 2026 07:58
toshi0806 added a commit to smkwlab/latex-environment that referenced this pull request Jun 3, 2026
Reference the shared preset at the v1 tag (github>smkwlab/.github:latex#v1)
so dependency-update behavior is resolved at a controlled version instead
of the default branch.

Follow-up to smkwlab/.github#29.
toshi0806 added a commit to smkwlab/thesis-management-tools that referenced this pull request Jun 3, 2026
Reference the shared preset at the v1 tag (github>smkwlab/.github:latex#v1)
so dependency-update behavior is resolved at a controlled version instead
of the default branch.

Follow-up to smkwlab/.github#29.
toshi0806 added a commit to smkwlab/latex-release-action that referenced this pull request Jun 3, 2026
Reference the shared preset at the v1 tag (github>smkwlab/.github:latex#v1)
so dependency-update behavior is resolved at a controlled version instead
of the default branch.

Follow-up to smkwlab/.github#29.
toshi0806 added a commit to smkwlab/thesis-management-tools that referenced this pull request Jun 3, 2026
* Use shared Renovate preset from smkwlab/.github

Replace the duplicated Renovate configuration with a one-line extends of
the org-wide shared preset (github>smkwlab/.github:latex). Behavior is
preserved; auto-merge for patch/digest updates is now applied per the
shared policy.

Depends on smkwlab/.github#28.

* Pin shared Renovate preset reference to v1

Reference the shared preset at the v1 tag (github>smkwlab/.github:latex#v1)
so dependency-update behavior is resolved at a controlled version instead
of the default branch.

Follow-up to smkwlab/.github#29.
toshi0806 added a commit to smkwlab/latex-release-action that referenced this pull request Jun 3, 2026
* Use shared Renovate preset from smkwlab/.github

Replace the duplicated Renovate configuration with a one-line extends of
the org-wide shared preset (github>smkwlab/.github:latex). Behavior is
preserved; auto-merge for patch/digest updates is now applied per the
shared policy.

Depends on smkwlab/.github#28.

* Pin shared Renovate preset reference to v1

Reference the shared preset at the v1 tag (github>smkwlab/.github:latex#v1)
so dependency-update behavior is resolved at a controlled version instead
of the default branch.

Follow-up to smkwlab/.github#29.
toshi0806 added a commit to smkwlab/latex-environment that referenced this pull request Jun 3, 2026
* Use shared Renovate preset from smkwlab/.github

Replace the duplicated Renovate configuration with a one-line extends of
the org-wide shared preset (github>smkwlab/.github:latex). Behavior is
preserved; auto-merge for patch/digest updates is now applied per the
shared policy.

Depends on smkwlab/.github#28.

* Pin shared Renovate preset reference to v1

Reference the shared preset at the v1 tag (github>smkwlab/.github:latex#v1)
so dependency-update behavior is resolved at a controlled version instead
of the default branch.

Follow-up to smkwlab/.github#29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants