chore: remove dependency-update.yml in favour of Renovate#24
Merged
Conversation
The reusable Elixir dependency-update workflow created PRs with the calling repository's `GITHUB_TOKEN`, which suppresses subsequent `pull_request` workflow runs and left required CI checks unsatisfied (BLOCKED state across smkwlab/tenbin_dns, tdig, tenbin_cache, elixir_dnstap, and tenbin_ex). Those repositories have been migrated to Renovate (renovate.json per repo), which runs as a GitHub App and is not subject to the token recursion restriction. A search of the smkwlab org confirms no other repository still uses this reusable workflow, so remove the file and its README entry.
There was a problem hiding this comment.
Pull request overview
This PR removes the organization’s reusable dependency-update.yml workflow and updates documentation to reflect that dependency updates are now handled exclusively by Renovate (as configured per-repo via renovate.json). This aligns with the stated background that PRs created via secrets.GITHUB_TOKEN don’t trigger downstream pull_request checks due to GitHub Actions recursion prevention, leaving required checks blocked.
Changes:
- Delete the reusable workflow
.github/workflows/dependency-update.yml. - Remove
dependency-update.ymlfrom the README workflow list and delete its documentation section. - Add a README note stating dependency updates are centralized to Renovate Bot.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Removes dependency-update.yml references and documents the move to Renovate. |
| .github/workflows/dependency-update.yml | Deletes the reusable dependency update workflow entirely. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
このワークフローは呼び出し元の `secrets.GITHUB_TOKEN` で PR を作成しており、GitHub Actions の再帰防止仕様 により後続の `pull_request` イベントが起動しません。結果として呼び出し側リポジトリ（smkwlab/tenbin_dns, tdig, tenbin_cache, elixir_dnstap, tenbin_ex）で必須チェック `ci / Code Quality` が走らず BLOCKED 状態が続いていました。
呼び出し側 5 リポジトリは Renovate に移行済み（各 repo の `renovate.json` を参照）。Renovate は GitHub App として動作するため再帰制限を受けません。
Cross-org usage check
`gh search code 'dependency-update.yml' org:smkwlab` でこの workflow を参照するファイルは smkwlab/.github 自身のみ。撤去しても他リポジトリへの影響はありません。
Follow-up