feat: relay Vue tsserver/request to sibling TypeScript server - #55
Merged
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Register vue-typescript beside the Vue language server, answer hybrid tsserver/request notifications by executeCommand to a sibling that advertises typescript.tsserverRequest, and pass @vue/typescript-plugin as initialization options when the package is present. Co-authored-by: Nicholas Adamou <nicholasadamou@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/vue-tsserver-relay-15fc
branch
from
August 29, 2026 12:16
763390e to
e751e63
Compare
Opening a .vue file now also tries the tsserver half; the unit test that only asserts the Vue language server can spawn must turn that sibling off so missing-install warnings do not fail it. Co-authored-by: Nicholas Adamou <nicholasadamou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port Vue hybrid-mode support: register a
vue-typescriptsibling (typescript-language-server +@vue/typescript-plugin), answertsserver/requestnotifications by relayingtypescript.tsserverRequestto that sibling (waiting through its handshake), and always reply — an unanswered request hangs completion in.vuefiles.Test plan
bun test test/lsp/vue-relay.test.tsx— resolve both servers, relay round-trip, unanswered still answersbun test test/lsp-servers.test.tsbun test test/app-lsp.test.ts— built-in vue spawn with sibling disabledNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.