feat: bind Ctrl+Space to show completions - #54
Merged
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hard-wire the usual autocomplete chord in the editor — terminals often deliver it as a bare NUL — reserve Ctrl+Space from rebinds, and advertise it in the palette hint and help overlay. Co-authored-by: Nicholas Adamou <nicholasadamou@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/complete-ctrl-space-15fc
branch
from
August 29, 2026 12:15
ec9ae5b to
788f589
Compare
nicholasadamou
marked this pull request as ready for review
August 29, 2026 12:28
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire
Ctrl+Space(and the bare NUL many terminals send for that chord) toeditor.completewhile the editor is focused. ReserveCtrl+Spacefrom custom rebinds — same family as other terminal control bytes — and advertise it on the palette command and in the shortcuts help.Test plan
bun test test/lsp-completion-ui.test.tsx— Ctrl+Space and NUL open the menubun test test/keybindings.test.tsx— Ctrl+Space rejected as reservedbun test test/help-scroll.test.tsxNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.