feat: richer Problems list modal with severity glyphs and detail

[nicholasadamou]

Summary

Replace the flat ChoiceModal problems picker with a dedicated list that matches how diagnostics are meant to be read: severity glyphs, an error/warning tally heading, column-aligned locations, optional source notes, and a fixed-height detail block for the selected message.

Also fixes cursor-scoped pick: Enter previously indexed into the full open-file rows instead of the scoped list, so jumping from “Problem at cursor” could land on the wrong diagnostic.

Test plan

• bun test test/lsp-ui.test.tsx — list shows tally/glyph/location; Enter jumps; cursor-scoped list jumps correctly
• CI green on this branch

  

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

Summary by CodeRabbit

• New Features

  • Added a dedicated problems modal showing diagnostics with severity totals, detailed messages, file locations, and keyboard navigation.
  • Preserved diagnostic sources and displays paths relative to the project.
  • Selecting a problem now jumps directly to its location, including from cursor-scoped results.

• Bug Fixes

  • Improved problem selection handling for diagnostics displayed in the modal.

• Tests

  • Added coverage for severity summaries, diagnostic details, cursor-scoped navigation, and jumping to selected problems.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e713a944-c899-47ad-886c-48b70b4fcf1b

📥 Commits

Reviewing files that changed from the base of the PR and between 41f9fd2 and 05e7e75.

📒 Files selected for processing (6)

• src/app/App.tsx
• src/app/AppView.tsx
• src/app/lsp/view.ts
• src/ui/modal.ts
• src/ui/overlays/ProblemsModal.tsx
• test/lsp-ui.test.tsx

---

📝 Walkthrough

Walkthrough

The application replaces choice-based diagnostic data with ProblemEntry objects and renders a dedicated ProblemsModal. The modal displays diagnostic details, supports keyboard navigation, preserves diagnostic sources, and jumps to the selected location.

Changes

Problems modal

Layer / File(s)	Summary
Problems modal implementation src/ui/modal.ts, src/ui/overlays/ProblemsModal.tsx	Adds cut and introduces a modal with severity counts, diagnostic details, keyboard navigation, source information, and selection controls.
Diagnostic entry pipeline src/app/lsp/view.ts, src/app/AppView.tsx, src/app/App.tsx	Replaces problemChoices with problemEntries. Selection now passes a problem object and calls jumpTo.
Modal behavior validation test/lsp-ui.test.tsx	Verifies modal content, severity counts, cursor-scoped selection, and navigation to the selected problem.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: cursoragent

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant ProblemUI
  participant ProblemsModal
  participant Editor
  App->>ProblemUI: request problemEntries
  ProblemUI-->>App: return diagnostic entries
  App->>ProblemsModal: render entries
  ProblemsModal->>ProblemUI: select ProblemChoice
  ProblemUI->>Editor: jumpTo diagnostic location

Loading

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/problems-modal-15fc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}