Fix/seed banner alignment 302 - #333
Merged
smaramwbc merged 1 commit intoAug 9, 2026
Merged
Conversation
smaramwbc
force-pushed
the
fix/seed-banner-alignment-302
branch
from
August 9, 2026 09:29
78959fb to
0d59f28
Compare
Owner
|
Thanks — nice fix. Auto-sizing the box to the longest line is the right call; I ran the helper against the real banner text and every border lines up exactly, including the One housekeeping thing, done rather than asked: I rebased your branch onto current Merging once CI is green. Thanks for closing out #302! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scripts/seed_demo_subjects.pyprinted a hand-drawn Unicode box banner with manually space-padded lines. One line (STATEWAVE_BOOTSTRAP_DEMO_PACKS=false) was longer than the fixed border width, so its closing│didn't align with the rest of the box in a monospace terminal. This PR replaces the manual banner with a_print_seed_banner()helper that auto-sizes the box to the longest line and pads every line to match, so the borders always align regardless of future wording changes.Related Issue
Closes #302
Type of Change
Changes Made
_print_seed_banner()helper function that computes box width from the longest line and pads every line to matchmain()with a call to_print_seed_banner()│on theSTATEWAVE_BOOTSTRAP_DEMO_PACKS=falseline as a side effect of the auto-sizingTesting
Test Commands Run
Checklist
Screenshots / Recordings
Additional Notes
No test suite exists for this script (it's a standalone data-seeding utility, not covered by
tests/), so verification was manual:ruff checkpassed, and running with--dry-runconfirms all box borders now align correctly, including the previously-overflowing line.