feat(tutorial): apply setup.rubyVersion in deck-setup foundation (#849)#855
Open
smalruby3-editor-bot[bot] wants to merge 2 commits into
Open
feat(tutorial): apply setup.rubyVersion in deck-setup foundation (#849)#855smalruby3-editor-bot[bot] wants to merge 2 commits into
smalruby3-editor-bot[bot] wants to merge 2 commits into
Conversation
deck 起動時の setup 基盤 (applyDeckSetup) は tab / rubyMode / extensions を 既に適用していたが、Issue で宣言された setup プロパティの rubyVersion だけ 未対応 (ドキュメントマーカーのみ) だった。これを実装して設計どおり完成させる。 - setup.rubyVersion (1|2 の数値、'1'|'2' の文字列どちらも受理) を正規化 - 設定メニュー / URL ローダーと同じく setRubyVersion dispatch + persistRubyVersion - 不正値・省略時は無視 (現状維持)。冪等・後方互換を維持 - 単体テスト 3 ケース追加 (数値/文字列/不正値)。全 13 ケース pass Closes #849 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
🤖 autopilot status
Linked issue #849. Maintained by autopilot (single writer); do not edit. |
Author
🤖 autopilot 敵対的レビュー (review フェーズ)別レビュアー視点で PR #855 の差分をレビューし、明白な点を自分で修正しました。 確認した観点と結論
自分で修正した点
人間レビューへ渡します。 |
takaokouji
approved these changes
Jul 1, 2026
|
🚀 Preview deployed: https://smalruby.jp/smalruby3-editor/topic/autopilot-849/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deck 起動時に環境をセットアップする横断機構 (
applyDeckSetup) のsetup.rubyVersion対応を追加します。この基盤機構 (
src/lib/deck-setup.js+tips-library.jsx連携) は先行 PR で develop にマージ済みで、setup.tab/setup.rubyMode/setup.extensionsは既に適用されていました。しかし Issue #849 が宣言したsetup: {tab, rubyMode, extensions, rubyVersion}のうちrubyVersionだけがドキュメントマーカーのみで未実装でした。本 PR でそれを実装し、Issue の仕様どおりに完成させます。Changes Made
src/lib/deck-setup.jssetup.rubyVersionを正規化 (1/2の数値、'1'/'2'の文字列どちらも受理、それ以外は無視)dispatch(setRubyVersion(...))+persistRubyVersion(...)(remount をまたいで保持)setup例にrubyVersionを追記test/unit/lib/deck-setup.test.jsTest Coverage
test/unit/lib/deck-setup.test.js— 全 13 ケース pass(新規 3 ケース含む)Notes
setup.rubyVersionを使う deck はまだ存在しないため(Phase 2 以降で追加予定)、既存 10 deck への影響はありません。Related Issues
Closes #849
Part of #679
🤖 Generated with Claude Code