Skip to content

Use IsAttestationFormatEnabled to check android-key format #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hslatman wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Draft

Use IsAttestationFormatEnabled to check android-key format #2768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions authority/provisioner/acme.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"fmt"
"net"
"net/http"
"slices"
"strings"
"sync/atomic"
"time"
Expand Down Expand Up @@ -512,7 +511,7 @@ func (p *ACME) GetAttestationRoots() (*x509.CertPool, bool) {
func (p *ACME) IsAndroidCertificateRevoked(ctx context.Context, cert *x509.Certificate) (bool, error) {
// the check only has to be performed when the "android-key" attestation
// format is enabled
if !slices.Contains(p.AttestationFormats, ANDROIDKEY) {
if !p.IsAttestationFormatEnabled(ctx, ANDROIDKEY) {
return false, nil
}

Expand Down