Conversation
Implementation of [RFC 7030] (https://datatracker.ietf.org/doc/html/rfc7030). Support TLS client certificate authentication and basic auth. Support webhook for authentication, notification and data. Not covered : * full CMC * server-side key generation
need for db migration and authority startup use replace in go.mod to use a linkedca version compatible (need for the build)
…uests Clean up code implementation
This removes some functionality that is not used with EST, simplifying the configuration and validation of the authority and EST provisioner. It stubs out some parts too, so that the code compiles again, albeit with a non-complete EST implementation.
The EST RFC describes that EST is always served on a well known path: `https://host:port/.well-known/est` It also supports paths that contain a label, supporting multiple authorities: `https://host:port/.well-known/some-label/est` Clients may be forming the URL to use based on just the base host URL, and may or may not support using a label. We'll thus have to keep that into account when serving EST. The fact that the label comes after `.well-known` is not great, as the label is then not namespaced. Anything else that we may want to serve there could now be pointing to an EST provisioner too. We currently don't know if EST clients support `/.well-known` to not sit at the root, or whether they support suffix path parts and/or query parameters. For now this is the conservative choice.
github-actions
Bot
added
the
needs triage
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if !s.authMethodsConfigured() { | ||
| s.DummyBool = &enable | ||
| } | ||
| if s.DummyBool == nil && (s.DummyString != "" || s.DummyString != "") { // TODO(hs): refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.