Add control_UDP node#8
Merged
Merged
Conversation
Member
|
Thank you! I can merge this as is, but SlowDash naming convention for the control node class is to use the Pascal case, capitalizing only the first letter even if it is an abbrivation (as commonly done in JavaScript, Java, C#/.NET, Swift, Kotlin, ...). So if you want to follow the coding style, it should be |
Contributor
Author
|
Thanks for the suggestion -- I have changed the name of the class to UdpSocketNode (and left the filename intact). |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new type of control node, UDPNode, with a design similar to (but simplified from) EthernetNode.
We add UDPNode to support devices communicating via connectionless datagrams (socket.SOCK_DGRAM), as the existing EthernetNode strictly implements connection-oriented TCP (socket.SOCK_STREAM).
Context:
Mason and I have been using UDP packets for many new sensors on the VDG. The following summary is from him:
In the beginning stages of our data acquisition renaissance we decided that UDP was the best method for our networked sensors to send data to our SlowDash server. This protocol was chosen only for diagnostic sensors (show hardware health) and NOT process sensors (trigger critical events).
Pros of using UDP
Cons of using UDP: