Conversation
gh release create already creates the git tag on the remote when it
doesn't yet exist (per gh release create --help). The separate 'Create
and push tag' step that followed it therefore attempted to push a tag
that already existed, which git rejected with:
! [rejected] v0.1.1 -> v0.1.1 (already exists)
Removing the redundant step lets gh release create own both the release
and the tag atomically. Downstream jobs (build-artifacts, publish-zed,
publish-neovim) already checkout ref: ${{ needs.tag-and-release.outputs.tag }}
and continue to work since the tag is created before they run.
fix: remove redundant tag push in release workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Replace this paragraph with a short narrative for the release. If left unchanged, GitHub's auto-generated notes will be used instead.