Attributes Component#157
Open
Auroali wants to merge 1 commit into
Open
Conversation
Owner
|
Hmm, I'm not sure it's safe to save and restore the entire attributes field. Can't that cause temporary modifiers to get stuck permanently? |
Author
|
ah. hm. i figured itd be ok due to most things adding non-persistent modifiers and the stuff that adds persistent modifiers being switched out anyways but there's probably cases where that's a problem. we have also run into issues with modifiers becoming permanent without switching attributes tho |
Author
|
i'm also just now realizing it would also break modifiers if the origins component were enabled and this was disabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix #143
also, should a preview field have been specified? i was unsure if hidden made that unnecessary or not