fix(dev): single-pass install build — capture artifact JSON from the real build - #609
Merged
Merged
Conversation
…the real build install-bins.rs used to build twice: the real build for the operator's progress output, then an identical re-run with --message-format=json to 'walk the cache for free' and discover the binary list. That second pass is only free on a quiescent filesystem: on winbox (2026-08-23) AV/sync tools touched the fresh artifacts between the passes, invalidated the fingerprints, and turned the discovery pass into a full second compile. The premise was wrong anyway — cargo always prints its human status and diagnostics on stderr, and --message-format=json-render-diagnostics only changes stdout. One invocation now streams the same live progress to the operator while the artifact JSON is drained concurrently from stdout (actively, so a filled pipe buffer can never deadlock the build) and parsed for the authoritative executable list. Discovery semantics unchanged (executable:null libraries skipped, sort/dedup); the second cargo invocation — and the invalidation window with it — is gone. Validated end-to-end via just use-local: 24 binaries discovered and installed from the single pass.
githubrobbi
enabled auto-merge
August 22, 2026 20:40
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 22, 2026
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer's binary-discovery re-ran the whole build with
--message-format=json, assuming a free cache walk. On winbox, AV/sync tools touching fresh artifacts between the two passes invalidated cargo's fingerprints and turned discovery into a full second compile (~6 min doubled).The premise was wrong anyway: cargo prints human status/diagnostics on stderr; JSON mode only changes stdout. One
--message-format=json-render-diagnosticsinvocation now gives the operator identical live progress while the artifact stream is drained concurrently (no pipe-buffer deadlock) and parsed for the authoritative executable list. Second invocation — and the invalidation window — gone.Tooling-only change (
scripts/dev/install-bins.rs): no version bump, no release — main just gets the new trick. Validated end-to-end viajust use-local: single build, 24 binaries discovered and installed.