pr/sknetwork rs core#595
Closed
nathandelara wants to merge 5 commits into
Closed
Conversation
nathandelara
commented
Jul 2, 2026
nathandelara
commented
Member
- Add sknetwork-rs core crate with CI and publish scaffolding.
- Harden Rust CI with bench-feature coverage and clippy checks.
Introduces the Rust port as an additive subtree under sknetwork-rs/: library source, Cargo metadata, LICENSE, README, docs, and publish check scripts. Benchmark harness (benchmarking/) is intentionally excluded; it lives on wip/full-port-with-benchmarks. Python packaging is unchanged (MANIFEST.in excludes sknetwork-rs). Adds rust_checks workflow for cargo test and docs. Co-authored-by: Cursor <cursoragent@cursor.com>
Runs all-target tests with the bench feature enabled and adds a clippy pass focused on panic/unwrap/indexing risk signals so regressions surface in PR CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #595 +/- ##
========================================
Coverage 98.22% 98.22%
========================================
Files 182 182
Lines 8356 8356
========================================
Hits 8208 8208
Misses 148 148 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
In CI, Lanczos can occasionally return fewer retained components than the requested max dimension while still producing a valid embedding. Update the options contract test to assert dimensions are within [1, min_dim] instead of exactly min_dim for Lanczos-backed PCA/SVD. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove duplicate license metadata warning by keeping SPDX `license` only and explicitly include README/LICENSE in the package include list. Improve the publish package gate to surface cargo package errors instead of swallowing stderr, making CI failures diagnosable. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace rg usage in publish gate scripts with POSIX grep so checks run on standard GitHub runners without extra tool dependencies. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
We prefer to keep a pure Python project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.