Firebase functions app check implementation#79
Open
IT-Guy007 wants to merge 9 commits into
Open
Conversation
Implement Firebase Storage listing and byte-level progress observation: add async list/maxResults/pageToken and listAll on StorageReference, introduce StorageListResult wrapper (items, prefixes, pageToken), and add StorageTaskStatus/StorageProgress/StorageTaskSnapshot types. Implement observe/removeObserver/removeAllObservers for UploadTask and FileDownloadTask (with internal observer tracking) and provide no-op/overrides for other download tasks. Update tests to exercise list APIs and observer types, and update README to reflect increased Storage support; remove related TODO comments.
Clamp Int64 maxResults to the Swift Int range before casting to Int to prevent overflow when calling platformValue.list(...). Adds a `clamped` variable and uses it in both list(maxResults:) overloads so large or small Int64 values won't cause invalid Int conversion.
Contributor
Author
|
Interestingly skip removes the set part of the function name, changed the builder and locally everything works |
marcprux
requested changes
May 15, 2026
Member
Skip doesn't remove the "set" part. I suspect you were just seeing a mis-match between the Swift and Android versions of the API, which isn't uncommon (the iOS version has a "require" that Android does't have): iOS: |
Contributor
Author
|
PR is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift testWrote the documentation and helped finding the names of the google functions