Conversation
nover
requested changes
Apr 6, 2018
nover
left a comment
nover
left a comment
Contributor
There was a problem hiding this comment.
@navidehsa Overall I think it looks good, I have a few comments for improvements.
| # hapi-test-utils | ||
|
|
||
| This package provides common helpers for testing [hapijs](https://hapijs.com/) code. | ||
| This package provides common helpers for testing API(unit test)[hapijs](https://hapijs.com/) code. |
Contributor
There was a problem hiding this comment.
Let's change it to:
This package provides common helpers for unit testing
| ## Routes | ||
|
|
||
| The `routing` namespace currently contains one helper for testing whether routes have been registered. Imagine some code like this | ||
| Imagine some code like this.We want to test `/hello` route with hapi-test-utils module |
| }); | ||
| ``` | ||
|
|
||
| add `mocha` to run the test. |
Contributor
There was a problem hiding this comment.
The given test suite in this example is actually written with jest :)
| This package provides common helpers for testing API(unit test)[hapijs](https://hapijs.com/) code. | ||
| It is currently compatible with hapi v17 and therefore also only works on nodejs 8. | ||
|
|
||
| Install the module as a dev dependency |
Contributor
There was a problem hiding this comment.
Let's add a comment and link to the examples folder here in the readme! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing Documentation and Adding Sample to projects