feat(trivy): default severity to all levels for cross-scanner dedup#42
Merged
Conversation
Scan wide with Trivy (UNKNOWN through CRITICAL) so osv-scanner overlaps on medium/low advisories by default; consumers can still narrow via scanners.trivy.severity while fail-on controls CI exit behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRITICAL,HIGHto all Trivy levels (UNKNOWNthroughCRITICAL), matching Trivy’s native--severitydefault.Detected bylines work without extra consumer config.scanners.trivy.severity;fail-onremains the knob for which findings fail the run.Motivation
Consumer repos (e.g. flightlogs-web) were seeing dependency findings with
Detected by: osv-scanneronly. That was expected: Trivy’s old default filtered out medium/low severities while osv-scanner reported everything. Widening the default follows a scan wide, fail narrow model.What changed
internal/config.DefaultTrivySeverities— single source of truth for the default listDefaults()andtrivy.buildArgs()— use all levels when no override is setmuninn.yml, and CI dedup workflow updated for v0.3.3Consumer impact
CRITICAL,HIGHfail-on: critical(default)Repos that want the old behavior can opt in:
Note: defining scanners: replaces the entire scanner map — list every scanner you still want enabled.
Test plan