Tweaks to HepMC3 converter. - #16
Draft
kjplows wants to merge 101 commits into
Draft
Conversation
add comment
Fix GCC 14 warnings (deprecated-copy, unused variables, sign-compare,shadow)
comment out unused parameter names instead of using (void)
fix memory leaks; add memory sanitizer
Fix missing Single Pion Production handling in gspl2root
fix potential uninitialized variable warnings
fix a typo in ion pdg code for hypernuclei
Bugfix: Ion pdg code for hypernuclei
Fix typo in Gabe's affiliation index
new layout option
…nerator into incl-hepmc3-marley
…c3 --> gntp to be lossless. Also move to PYTHIA8
…oubleAttribute`. Needed to store kinematic variables with enough precision in the ASCII representation of HepMC3 so as not to be lossy. Diff tests from GHEP --> ASCII --> GHEP were lossy before this commit and showed nontrivial if small (~0.01%) differences in inelasticity, lepton costheta, and xBj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the behaviour of the
HepMCNtpWriterandHepMCConverterclasses to handle tune setting and mothers and daughters plus some attributes that were not identical between ghep and hepmc outputs.Tested across the single-generator threads of standard GENIE (using tune AR23_20i_00_000) with 100 events / thread, numu on Ar40 (apart from diffractive, H1).
Conversion to hepmc3 from ghep: tested by writing out hepmc + ghep output simultaneously (
-o foo.ghep.root,ghep,bar.hepmc.txt,hepmc) and diffing the output txt files.Conversion to ghep from hepmc3: tested with gevdump on each event of each thread.