Skip to content

feat: six-icon now supports custom svgs#445

Open
fortesp wants to merge 4 commits into
mainfrom
feat/six-icon-with-svg-support
Open

feat: six-icon now supports custom svgs#445
fortesp wants to merge 4 commits into
mainfrom
feat/six-icon-with-svg-support

Conversation

@fortesp
Copy link
Copy Markdown
Collaborator

@fortesp fortesp commented Nov 19, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

#425

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@fortesp fortesp linked an issue Nov 19, 2025 that may be closed by this pull request
@fortesp fortesp self-assigned this Nov 19, 2025
@fortesp fortesp requested a review from pennal November 19, 2025 10:52
@pennal pennal added this to the v5.2.0 milestone Nov 19, 2025
Comment thread libraries/ui-library/src/components/six-icon/six-icon.tsx Outdated
Comment thread libraries/ui-library/src/components/six-icon/six-icon.tsx Outdated
Comment thread libraries/ui-library/src/components/six-icon/six-icon.tsx
Comment thread libraries/ui-library/src/components/six-icon/six-icon.tsx
Comment thread libraries/ui-library/src/components/six-icon/six-icon.tsx Outdated
Comment thread libraries/ui-library/src/components/six-icon/six-icon.tsx Outdated
Comment thread libraries/ui-library/src/components/six-icon/index.html Outdated
Comment thread libraries/ui-library/src/components/six-icon/six-icon.scss Outdated
Comment thread docs/components/six-icon.md
Comment thread docs/components/six-icon.md
@colinscz colinscz modified the milestones: v5.2.0, v5.3.0 Nov 28, 2025
@colinscz colinscz modified the milestones: v5.3.0, v5.4.0 Feb 5, 2026
@rspy rspy requested review from rspy and removed request for ibirrer and tkst8 March 4, 2026 15:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

File Coverage
All files 92%
www/build/src/components/six-breadcrumbs/six-breadcrumbs.tsx 83%
www/build/src/components/six-button/six-button.tsx 91%
www/build/src/components/six-checkbox/six-checkbox.tsx 93%
www/build/src/components/six-date/calendar-grid.ts 93%
www/build/src/components/six-date/six-date.tsx 96%
www/build/src/components/six-date/components/month-selection.tsx 90%
www/build/src/components/six-date/components/year-selection.tsx 91%
www/build/src/components/six-details/six-details.tsx 98%
www/build/src/components/six-dialog/six-dialog.tsx 98%
www/build/src/components/six-dropdown/six-dropdown.tsx 94%
www/build/src/components/six-error-page/six-error-page.tsx 90%
www/build/src/components/six-file-upload/six-file-upload.tsx 95%
www/build/src/components/six-group-label/six-group-label.tsx 83%
www/build/src/components/six-icon/six-icon.tsx 66%
www/build/src/components/six-icon-button/six-icon-button.tsx 90%
www/build/src/components/six-input/six-input.tsx 97%
www/build/src/components/six-item-picker/six-item-picker.tsx 99%
www/build/src/components/six-menu/six-menu.tsx 80%
www/build/src/components/six-menu-item/six-menu-item.tsx 99%
www/build/src/components/six-paginator/six-paginator.tsx 90%
www/build/src/components/six-picto/six-picto.tsx 66%
www/build/src/components/six-progress-ring/six-progress-ring.tsx 75%
www/build/src/components/six-range/six-range.tsx 92%
www/build/src/components/six-rating/six-rating.tsx 96%
www/build/src/components/six-search-field/six-search-field.tsx 90%
www/build/src/components/six-select/six-select.tsx 88%
www/build/src/components/six-select/util.ts 75%
www/build/src/components/six-sidebar/six-sidebar.tsx 92%
www/build/src/components/six-sidebar-item-group/six-sidebar-item-group.tsx 95%
www/build/src/components/six-switch/six-switch.tsx 95%
www/build/src/components/six-tab/six-tab.tsx 91%
www/build/src/components/six-tab-group/six-tab-group.tsx 78%
www/build/src/components/six-textarea/six-textarea.tsx 87%
www/build/src/components/six-tile/six-tile.tsx 83%
www/build/src/components/six-tooltip/six-tooltip.tsx 94%
www/build/src/functional-components/form-control/form-control.tsx 89%
www/build/src/utils/animation.ts 88%
www/build/src/utils/error-messages.ts 84%
www/build/src/utils/event-listeners.ts 91%
www/build/src/utils/execution-control.ts 90%
www/build/src/utils/focus-visible.ts 83%
www/build/src/utils/icon.ts 92%
www/build/src/utils/modal.ts 75%
www/build/src/utils/popover.ts 83%
www/build/src/utils/scroll.ts 87%
www/build/src/utils/slot.ts 90%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 5529670

@rspy
Copy link
Copy Markdown
Collaborator

rspy commented Mar 4, 2026

Please forgive me if I'm not quite seeing through everything ;-) But there seem to be a lot of commits in this PR which have nothing to do with it, like the ones from Béla and Joel.
Shouldn't there be only these 12 commits in the PR?
main...feat/six-icon-with-svg-support

Comment thread libraries/ui-library/src/components/six-icon/index.html Outdated
Comment thread docs/public/assets/demo-icon.svg
Comment thread libraries/ui-library/src/components/six-icon/six-icon.scss Outdated
@pennal
Copy link
Copy Markdown
Collaborator

pennal commented Mar 11, 2026

Can you rebase this branch @rspy? I am seeing over 500 changed fiels which makes it a bit difficult to review 😅

@colinscz colinscz modified the milestones: v5.4.0, v5.5.0 Mar 23, 2026
@fortesp fortesp force-pushed the feat/six-icon-with-svg-support branch from 5529670 to 2d8ae53 Compare June 1, 2026 08:55
@fortesp fortesp force-pushed the feat/six-icon-with-svg-support branch from 2d8ae53 to e126c11 Compare June 1, 2026 09:30
fortesp added 2 commits June 1, 2026 12:38
Removes test.svg from src/assets/ (which gets copied to dist) and renames
the component-local demo asset to demo-icon.svg. Adds a copy under
docs/public/assets/ so docs examples resolve correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

six-icon with SVG support

4 participants