feat: six-icon now supports custom svgs#445
Open
fortesp wants to merge 4 commits into
Open
Conversation
pennal
requested changes
Nov 20, 2025
Contributor
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5529670 |
Collaborator
|
Please forgive me if I'm not quite seeing through everything ;-) But there seem to be a lot of commits in this PR which have nothing to do with it, like the ones from Béla and Joel. |
rspy
reviewed
Mar 4, 2026
Collaborator
|
Can you rebase this branch @rspy? I am seeing over 500 changed fiels which makes it a bit difficult to review 😅 |
5529670 to
2d8ae53
Compare
2d8ae53 to
e126c11
Compare
Removes test.svg from src/assets/ (which gets copied to dist) and renames the component-local demo asset to demo-icon.svg. Adds a copy under docs/public/assets/ so docs examples resolve correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
#425
📝 Checklist
mainbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: