Skip to content

Refresh app branding and launch icons - #3

Merged
siure merged 3 commits into
mainfrom
feature/branding-icons
Mar 29, 2026
Merged

Refresh app branding and launch icons#3
siure merged 3 commits into
mainfrom
feature/branding-icons

Conversation

@siure

@siure siure commented Mar 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replace the Electron renderer brand mark with the new logo asset and align its sizing in CSS.
  • Update Android launcher assets and foreground/background resources to use the new branding.
  • Bump the package version to 0.3.1.

Testing

  • Not run
  • Visual check the Electron header logo renders correctly at 28x28.
  • Verify Android launcher icons build from the updated mipmap and drawable resources.

- Refresh Android launcher assets
- Replace Electron brand icon with shared logo
- Bump crate version to 0.3.1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f27fd49ac7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +7 to +9
<bitmap
android:gravity="center"
android:src="@drawable/ic_launcher_foreground_image" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Scale launcher foreground bitmap to adaptive-icon bounds

On Android 8+ this file is used as the adaptive icon foreground, but the new @drawable/ic_launcher_foreground_image asset is a 1024×1024 drawable-nodpi bitmap and android:gravity="center" does not scale it to the 72dp inset area. The result is that launchers can render only the center-cropped portion of the logo (zoomed/clipped icon) instead of the full mark. Please use a properly sized density-aware foreground drawable (or a vector) so the full icon fits the adaptive icon viewport.

Useful? React with 👍 / 👎.

- Add density-specific launcher foreground PNGs
- Replace inset wrapper with direct bitmap drawable
@siure
siure merged commit 8e12d40 into main Mar 29, 2026
6 checks passed
@siure
siure deleted the feature/branding-icons branch March 29, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant