Refresh app branding and launch icons - #3
Conversation
- Refresh Android launcher assets - Replace Electron brand icon with shared logo - Bump crate version to 0.3.1
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f27fd49ac7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <bitmap | ||
| android:gravity="center" | ||
| android:src="@drawable/ic_launcher_foreground_image" /> |
There was a problem hiding this comment.
Scale launcher foreground bitmap to adaptive-icon bounds
On Android 8+ this file is used as the adaptive icon foreground, but the new @drawable/ic_launcher_foreground_image asset is a 1024×1024 drawable-nodpi bitmap and android:gravity="center" does not scale it to the 72dp inset area. The result is that launchers can render only the center-cropped portion of the logo (zoomed/clipped icon) instead of the full mark. Please use a properly sized density-aware foreground drawable (or a vector) so the full icon fits the adaptive icon viewport.
Useful? React with 👍 / 👎.
- Add density-specific launcher foreground PNGs - Replace inset wrapper with direct bitmap drawable
Summary
0.3.1.Testing
28x28.