Skip to content

Refactor file opening to use context manager #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twalen merged 1 commit into from
Apr 8, 2026
Merged

Refactor file opening to use context manager #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion filetracker/client/data_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def add_file(self, name, filename, compress_hint=True):
Works like :meth:`add_stream`, but ``filename`` is the name of
an existing file in the filesystem.
"""
return self.add_stream(name, open(filename, 'rb'))
with open(filename, 'rb') as f:
return self.add_stream(name, f)

def exists(self, name):
"""Returns ``True`` if the file exists, ``False`` otherwise.
Expand Down
Loading