Partition duration for time structures#95
Open
JulStraus wants to merge 8 commits into
Open
Conversation
- To be added for other time structures
* OperationalScenarios
* RepresentativePeriods
* RepresentativePeriods{OperationalScenarios}
Collaborator
Author
|
I added now support for most of the available time structures, excluding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first take on including partitions based on the duration of operational periods as outlined in #94. There are a few things to highlight:
The introduction of the
PartitionDurationabstract type enablesHowever, it requires the introduction of subtypes for all potential combinations. This is a bit annoying, but does not require to much work either.
There are still a few open questions:
My plan is now to
Important
I consider partitions only to be relevant for operational periods. The reason is that it does not make sense, at least in my opinion, to have partitions of operational scenarios. It could theoretically make sense for representative periods or strategic periods, but I think it is better to not allow for it at the current stage.