Skip to content

[Deathknight] Echoing fury bug implemented for blood #11502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Armadk merged 2 commits into from
Jun 11, 2026
Merged

[Deathknight] Echoing fury bug implemented for blood #11502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
556aa2f
[Deathknight] Echoing fury bug implemented for blood
Armadk Jun 11, 2026
b01ee1a
[Deathknight] Support empowered casts for drw echoing fury
Armadk Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions engine/class_modules/sc_death_knight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8242,6 +8242,14 @@ struct reapers_mark_t final : public death_knight_spell_t
( as<int>( p()->talent.deathbringer.deathly_blows->effectN( 4 ).base_value() ) ) );

if ( p()->specialization() == DEATH_KNIGHT_FROST && p()->talent.deathbringer.echoing_fury.ok() )
{
p()->buffs.exterminate->trigger( exterm_stacks );
debug_cast<exterminate_t*>( p()->background_actions.exterminate )->empowered = exterm_stacks;
debug_cast<exterminate_aoe_t*>( p()->background_actions.exterminate_aoe )->empowered = exterm_stacks;
}

// Tested and confirmed June 11th 2026. Casting reapers mark gives 1 stack on blood, but should only apply to Frost
if ( p()->bugs && p()->specialization() == DEATH_KNIGHT_BLOOD && p()->talent.deathbringer.echoing_fury.ok() )
{
p()->buffs.exterminate->trigger( exterm_stacks );
debug_cast<exterminate_t*>( p()->background_actions.exterminate )->empowered = exterm_stacks;
Expand Down Expand Up @@ -9148,6 +9156,9 @@ struct dancing_rune_weapon_t final : public death_knight_spell_t
parse_options( options_str );

p->pets.dancing_rune_weapon_pet.set_creation_event_callback( pets::parent_pet_action_fn( this ) );

if ( p->talent.deathbringer.echoing_fury.ok() )
exterm_stacks = as<int>( p->talent.deathbringer.echoing_fury->effectN( 4 ).base_value() );
}

void execute() override
Expand All @@ -9174,11 +9185,16 @@ struct dancing_rune_weapon_t final : public death_knight_spell_t
p()->buffs.gift_of_the_sanlayn->trigger( p()->talent.blood.dancing_rune_weapon->duration() );

if ( p()->talent.deathbringer.echoing_fury.ok() )
{
p()->buffs.exterminate->trigger();
debug_cast<exterminate_t*>( p()->background_actions.exterminate )->empowered = exterm_stacks;
debug_cast<exterminate_aoe_t*>( p()->background_actions.exterminate_aoe )->empowered = exterm_stacks;
}
}

private:
int bone_shield_stack_gain;
int exterm_stacks;
};

// Dark Command =============================================================
Expand Down
Loading