Add multi-client support#92
Open
codemonium wants to merge 3 commits intosimplepractice:mainfrom
Open
Conversation
Contributor
Author
|
There are still several usages of I left them alone because the change already does what I want, and I don't know the best approach forward for logging. Should logging be client-specific, or should there be one global logger? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DRAdd support for using multiple
Langfuse::Clientinstances while preserving the existing singleton client behavior.WhySome applications need to report to more than one Langfuse project from the same process, such as separate "Meeting Transcription" and "Note Summarization" projects. The SDK previously assumed singleton usage in a few internal paths, which made multi-client usage require downstream monkey patches.
Checklist