Raise a clear error for schema DSL fields with no name#1469
Open
code-with-rashid wants to merge 1 commit into
Open
Raise a clear error for schema DSL fields with no name#1469code-with-rashid wants to merge 1 commit into
code-with-rashid wants to merge 1 commit into
Conversation
schema_dsl() crashed with an opaque IndexError when a field had no name before the colon (e.g. ":description" or "name, :description"), because splitting the empty left-hand side yields no parts and field_parts[0] is out of range. Raise a ValueError naming the offending field instead. Closes simonw#1466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
schema_dsl()crashes with an opaqueIndexErrorwhen a field has no name before the colon (reachable from the CLI viallm schema dsl ':foo'and fromresolve_schema_input):After
field.split(":", 1)the left-hand side is empty, sofield_info.strip().split()returns[]andfield_parts[0]is out of range.This raises a
ValueErrornaming the offending field instead, so the cause is obvious:Valid schemas are unaffected.
Tests
Added
test_schema_dsl_missing_field_name(parametrized over':just a description'and'name, :description') asserting theValueError.pytest tests/test_utils.pypasses (84 tests).Closes #1466