Skip broken plugin entrypoints during plugin loading#1465
Open
2830500285 wants to merge 1 commit into
Open
Conversation
Catch exceptions from installed llm entry points one plugin at a time so a crashing third-party plugin no longer prevents the CLI from starting. Add regression coverage for skipped plugins and the LLM_RAISE_PLUGIN_ERRORS debug path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llmentry points one at a time so a crashing third-party plugin is skipped instead of preventing the CLI from startingLLM_RAISE_PLUGIN_ERRORS=1for debuggingFixes #1280
Tests
uv run pytest tests/test_plugins.py -quv run pytest -quv run ruff check .uv run black . --checkuv run mypy llmuv run cog --check -p "import sys, os; sys._called_from_test=True; os.environ['LLM_USER_PATH'] = '/tmp'" README.md docs/*.md