Google tag manager#186
Conversation
kendraSO
left a comment
There was a problem hiding this comment.
Have we discussed removing this file with the EM:RAP team? StoreAnalyticsOrderTracker is still being used by this class
Which is in use in some layouts
Great catch. I was told that emrap didn't use google analytics (and seemed natural not outdated bing, twitter) anymore. It still inherits from StoreAnalyticsOrderTracker even though it's basically only used for Amplitude — probably makes sense to move the handful of methods down into RapAnalyticsOrderTracker, but that's up to the emrap team priorities and timelines. I just restored StoreAnalyticsOrderTracker.php back in place in Store but course-host repo will not reference it (the plan was to release as a new major version (indicating breaking chance), in which case emrap would update only when it actually needed new changes in the library and bump their dependency to the next major version, make necessary adjustments, at that time). |
2e21e92 to
b1e6005
Compare
Google Tag Manager replaces GA4, OrderTracker class moved downstream to course-host repo level.
Technically a breaking change, so should be released at a new major semver.