Skip to content

Google tag manager#186

Merged
wittman merged 8 commits into
silverorange:masterfrom
wittman:google-tag-manager
Mar 16, 2026
Merged

Google tag manager#186
wittman merged 8 commits into
silverorange:masterfrom
wittman:google-tag-manager

Conversation

@wittman
Copy link
Copy Markdown
Contributor

@wittman wittman commented Mar 13, 2026

Google Tag Manager replaces GA4, OrderTracker class moved downstream to course-host repo level.

Technically a breaking change, so should be released at a new major semver.

@wittman
Copy link
Copy Markdown
Contributor Author

wittman commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

@kendraSO kendraSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we discussed removing this file with the EM:RAP team? StoreAnalyticsOrderTracker is still being used by this class

Which is in use in some layouts

@wittman
Copy link
Copy Markdown
Contributor Author

wittman commented Mar 14, 2026

Have we discussed removing this file with the EM:RAP team? StoreAnalyticsOrderTracker is still being used by this class

Which is in use in some layouts

Great catch. I was told that emrap didn't use google analytics (and seemed natural not outdated bing, twitter) anymore. It still inherits from StoreAnalyticsOrderTracker even though it's basically only used for Amplitude — probably makes sense to move the handful of methods down into RapAnalyticsOrderTracker, but that's up to the emrap team priorities and timelines.

I just restored StoreAnalyticsOrderTracker.php back in place in Store but course-host repo will not reference it (the plan was to release as a new major version (indicating breaking chance), in which case emrap would update only when it actually needed new changes in the library and bump their dependency to the next major version, make necessary adjustments, at that time).

@wittman wittman force-pushed the google-tag-manager branch from 2e21e92 to b1e6005 Compare March 16, 2026 19:15
@wittman wittman merged commit dc5a389 into silverorange:master Mar 16, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants