Skip to content

fix(pdf): drop --single-process - #449

Merged
nossila merged 1 commit into
masterfrom
fix/pdf-chrome-single-process
Aug 6, 2026
Merged

fix(pdf): drop --single-process#449
nossila merged 1 commit into
masterfrom
fix/pdf-chrome-single-process

Conversation

@Janekk

@Janekk Janekk commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

— it crashes recent headless Chrome (SIGTRAP)

google-chrome-stable 151 SIGTRAPs on headless print-to-pdf with --single-process (an unsupported/deprecated flag), failing every baseapp_pdf integration test. The CI image installs google-chrome-stable unpinned, so any rebuild pulls the broken version (master will hit this on its next rebuild too). Multi-process headless (the default) renders fine with the existing --no-sandbox / --disable-dev-shm-usage flags.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Chrome PDF rendering reliability by removing an outdated browser launch option.

…SIGTRAP)

google-chrome-stable 151 SIGTRAPs on headless print-to-pdf with --single-process
(an unsupported/deprecated flag), failing every baseapp_pdf integration test. The
CI image installs google-chrome-stable unpinned, so any rebuild pulls the broken
version (master will hit this on its next rebuild too). Multi-process headless (the
default) renders fine with the existing --no-sandbox / --disable-dev-shm-usage flags.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 6, 2026 13:02
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eaf295bb-3649-4bf3-b290-6f4ae8bcc1fc

📥 Commits

Reviewing files that changed from the base of the PR and between f17430c and 2fb56ea.

📒 Files selected for processing (1)
  • baseapp_pdf/utils.py
💤 Files with no reviewable changes (1)
  • baseapp_pdf/utils.py

Walkthrough

The Chrome PDF rendering command no longer includes the --single-process option.

Changes

PDF rendering

Layer / File(s) Summary
Chrome command arguments
baseapp_pdf/utils.py
The PDF rendering command no longer passes --single-process to Chrome.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot, hercilio1

Poem

A rabbit checks the Chrome command,
One flag now rests beneath the sand.
PDFs hop through a cleaner track,
No single-process flag comes back.
Fluffy ears approve the change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the deprecated --single-process flag from PDF generation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pdf-chrome-single-process

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the reliability of PDF rendering in baseapp_pdf by removing the deprecated/unsupported Chrome flag --single-process, which can crash newer headless Chrome versions during --print-to-pdf.

Changes:

  • Remove --single-process from the google-chrome invocation used by render_to_pdf.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nossila
nossila merged commit 1a7c705 into master Aug 6, 2026
10 checks passed
@nossila
nossila deleted the fix/pdf-chrome-single-process branch August 6, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants