fix(pdf): drop --single-process - #449
Conversation
…SIGTRAP) google-chrome-stable 151 SIGTRAPs on headless print-to-pdf with --single-process (an unsupported/deprecated flag), failing every baseapp_pdf integration test. The CI image installs google-chrome-stable unpinned, so any rebuild pulls the broken version (master will hit this on its next rebuild too). Multi-process headless (the default) renders fine with the existing --no-sandbox / --disable-dev-shm-usage flags. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe Chrome PDF rendering command no longer includes the ChangesPDF rendering
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability of PDF rendering in baseapp_pdf by removing the deprecated/unsupported Chrome flag --single-process, which can crash newer headless Chrome versions during --print-to-pdf.
Changes:
- Remove
--single-processfrom thegoogle-chromeinvocation used byrender_to_pdf.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
— it crashes recent headless Chrome (SIGTRAP)
google-chrome-stable 151 SIGTRAPs on headless print-to-pdf with --single-process (an unsupported/deprecated flag), failing every baseapp_pdf integration test. The CI image installs google-chrome-stable unpinned, so any rebuild pulls the broken version (master will hit this on its next rebuild too). Multi-process headless (the default) renders fine with the existing --no-sandbox / --disable-dev-shm-usage flags.
Summary by CodeRabbit