fix(reports): make report-type query tests hermetic for parallel runs - #447
Open
Janekk wants to merge 1 commit into
Open
fix(reports): make report-type query tests hermetic for parallel runs#447Janekk wants to merge 1 commit into
Janekk wants to merge 1 commit into
Conversation
The allReportTypes query tests asserted on migration-seeded ReportType rows (counts of 8/11). Any TransactionTestCase in the suite truncates those rows (Django does not restore migration data without serialized_rollback), so under pytest-xdist the wipe can land before these tests on a shared worker DB, making them flaky. Create and assert on the tests' own ReportType rows (explicit keys, membership assertions) instead of the seeded defaults, so they are order- and scheduler-independent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hercilio1
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allReportTypes query tests asserted on migration-seeded ReportType rows (counts of 8/11). Any TransactionTestCase in the suite truncates those rows (Django does not restore migration data without serialized_rollback), so under pytest-xdist the wipe can land before these tests on a shared worker DB, making them flaky.
Create and assert on the tests' own ReportType rows (explicit keys, membership assertions) instead of the seeded defaults, so they are order- and scheduler-independent.