fix(cleanup): preserve attached block devices - #295
Draft
Q-Dub wants to merge 6 commits into
Draft
Conversation
lauri-amd
previously approved these changes
Aug 7, 2026
Remove the legacy disk hot-removal sweep so cleanup cannot detach virtio-SCSI cloud volumes after wiping them. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve canonical block-device identities, protect system dependency chains, strictly parse Bloom fstab records, and compare configured storage with live state before destructive cleanup. Co-authored-by: Cursor <cursoragent@cursor.com>
Guard every wipe against protected and mounted device trees, restrict fstab mutations to validated entries, preserve untagged Rancher storage, revalidate premounted sources, and make Longhorn iSCSI parsing field-position independent. Add regression coverage for strict tags, root-device rejection, explicit empty configs, and parser edge cases. Co-authored-by: Cursor <cursoragent@cursor.com>
Add cleanup --preflight-only, fail on unreadable configs, lock resolved disk scope before confirmation, and rerun validation immediately before both standalone cleanup and --destroy-data teardown. Co-authored-by: Cursor <cursoragent@cursor.com>
Describe preflight-only usage, config/fstab/live-state checks, protected device chains, strict Rancher ownership, repeated validation, and the corrected wipe-and-reformat cleanup behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Q-Dub
force-pushed
the
EAI-7797_virtio_scsi_disk_detach
branch
from
August 10, 2026 05:36
8edbe23 to
89ec209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the legacy disk hot-removal sweep so cleanup cannot detach virtio-SCSI cloud volumes after wiping them.