Skip to content

refactor: remove unused _is_buffer_empty method #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morcux wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: remove unused _is_buffer_empty method #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b860298
fix: gracefully handle empty byte array in leb128 decoding
morcux Mar 10, 2026
1232939
refactor: remove unused _is_buffer_empty method
morcux Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pybyntic/buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ class Buffer:
def __init__(self, data: bytes):
self.buffer = bytearray(data)

def _is_buffer_empty(self) -> bool:
return len(self.buffer) == 0

def is_buffer_readable(self) -> bool:
if len(self.buffer) == 0:
return False
Expand All @@ -31,6 +28,8 @@ def read_varint(self) -> int:
packets.append(packet)
if packet < 0x80:
break
if not packets:
return 0
return leb128.u.decode(packets) # type: ignore

def read_bytes(self, length: int) -> bytearray:
Expand Down