Skip to content

Use ProgressiveTransactions type for the IL transactions field - #9747

Merged
mergify[bot] merged 10 commits into
sigp:unstablefrom
conache:followup-use-progressive-list-for-il-transactions
Aug 12, 2026
Merged

Use ProgressiveTransactions type for the IL transactions field#9747
mergify[bot] merged 10 commits into
sigp:unstablefrom
conache:followup-use-progressive-list-for-il-transactions

Conversation

@conache

@conache conache commented Aug 4, 2026

Copy link
Copy Markdown

Issue Addressed

Follow-up to #9708 , resolving the outstanding switch of InclusionList.transactions to ProgressiveTransactions.
This was unblocked by the merge of #9450.

Proposed Changes

  • Switch InclusionList.transactions from Transactions<E> to ProgressiveTransactions, matching the spec type
  • Since no field depends on EthSpec anymore, InclusionList and SignedInclusionList drop this type parameter

@eserilev eserilev added focil Fork choice enforced inclusion lists heze labels Aug 4, 2026
@rahulbarmann

Copy link
Copy Markdown

A heads up, inclusion_list_committee_root is gone from InclusionList as of consensus-specs#5513, replaced by dependent_root. I just raised #9774 for the rename so it stays separate from this and can be reviewed and merged quickly, so whichever lands first the other needs a one-line rebase.

The same spec PR also changes IL production: get_signed_inclusion_list sets dependent_root via get_shuffling_dependent_root, which returns Root() for the first two epochs after Heze genesis and would get those ILs dropped. That is left unfixed in the spec, but our duties endpoints already pass chain.genesis_block_root as the fallback decision root, so probably worth handling the early epochs the same way here.

@eserilev

Copy link
Copy Markdown
Member

once conflicts are resolved ill merge

@conache

conache commented Aug 10, 2026

Copy link
Copy Markdown
Author

once conflicts are resolved ill merge

Just resolved the conflicts. Should be good to go 🙏

@eserilev eserilev added the ready-for-review The code is ready for review label Aug 10, 2026

@eserilev eserilev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eserilev eserilev added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 11, 2026
@mergify mergify Bot added the queued label Aug 11, 2026
@mergify

mergify Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 5 minutes 16 seconds in the queue, including 3 minutes 11 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

  • local-testnet-success

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@eserilev

Copy link
Copy Markdown
Member

looks like some clippy issues @conache make sure to run make lint full and cargo fmt --all

@mergify mergify Bot removed the dequeued label Aug 11, 2026
@conache

conache commented Aug 11, 2026

Copy link
Copy Markdown
Author

looks like some clippy issues @conache make sure to run make lint full and cargo fmt --all

@eserilev this should be fixed now in f5b5731

@eserilev

Copy link
Copy Markdown
Member

@mergify requeue

@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 29 minutes 40 seconds in the queue, including 28 minutes 18 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Aug 12, 2026
@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown

requeue

☑️ This pull request is already queued

@mergify
mergify Bot merged commit e6a90c1 into sigp:unstable Aug 12, 2026
37 of 38 checks passed
@mergify mergify Bot removed the queued label Aug 12, 2026
@conache
conache deleted the followup-use-progressive-list-for-il-transactions branch August 12, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

focil Fork choice enforced inclusion lists heze ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants