Skip to content

Fix menu component#192

Merged
pdrbrnd merged 1 commit into
mainfrom
fix/menu
May 5, 2026
Merged

Fix menu component#192
pdrbrnd merged 1 commit into
mainfrom
fix/menu

Conversation

@marcelines
Copy link
Copy Markdown
Contributor

What changed

  • Fixed the menu layering behavior by ensuring sticky section headers use the intended stacking order in src/components/menu.tsx (Disclosure.Trigger with z-10).
  • Updated workspace formatter settings in .vscode/settings.json to enforce project-consistent save behavior:
    • Biome for javascript, javascriptreact, typescript, and typescriptreact
    • Prettier for astro
    • Biome fixes on save via source.fixAll.biome: "always"

Fix

  • Resolves menu z-index/stacking issues during scroll so sticky menu headers render in the correct visual layer.
  • Prevents formatting drift while touching menu code by ensuring TS/TSX files are formatted by Biome instead of accidentally falling back to Prettier.

Before

screenshot-menu-1

After

screenshot-menu-2

Why .vscode/settings.json changed

  • The project intentionally uses Biome for JS/TS and Prettier for Astro, but formatter precedence can still be affected by user-level language-specific defaults.
  • Adding explicit per-language formatter settings at workspace level ensures this repo’s styling rules are applied consistently for all contributors.
  • Enabling Biome fix-on-save also applies lint-driven fixes (including class sorting where configured) as part of normal save flow.

@pdrbrnd pdrbrnd merged commit 9aec134 into main May 5, 2026
2 checks passed
@pdrbrnd pdrbrnd deleted the fix/menu branch May 5, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants